Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: refine ready message #2262

Merged
merged 3 commits into from
Aug 25, 2023
Merged

playground: refine ready message #2262

merged 3 commits into from
Aug 25, 2023

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Aug 23, 2023

What problem does this PR solve?

#2202 (comment)

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from nexustar August 23, 2023 07:01
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 23, 2023
@xhebox xhebox mentioned this pull request Aug 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Aug 23, 2023

Codecov Report

Patch coverage: 57.14% and no project coverage change.

Comparison is base (eee25bb) 55.83% compared to head (a599bc3) 55.83%.

❗ Current head a599bc3 differs from pull request most recent head 42cd979. Consider uploading reports for the commit 42cd979 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2262      +/-   ##
==========================================
- Coverage   55.83%   55.83%   -0.00%     
==========================================
  Files         321      321              
  Lines       34017    34022       +5     
==========================================
+ Hits        18991    18993       +2     
- Misses      12754    12755       +1     
- Partials     2272     2274       +2     
Flag Coverage Δ
playground 15.71% <57.14%> (+0.01%) ⬆️
tiup 15.86% <ø> (ø)
unittest 22.58% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
components/playground/playground.go 46.01% <50.00%> (-0.03%) ⬇️
components/playground/main.go 59.42% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 24, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the lgtm label Aug 24, 2023
@ti-chi-bot ti-chi-bot bot added the lgtm label Aug 25, 2023
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Aug 25, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-08-24 18:52:17.671867911 +0000 UTC m=+1434702.220883883: ☑️ agreed by kaaaaaaang.
  • 2023-08-24 18:52:35.93019914 +0000 UTC m=+1434720.479215112: ✖️🔁 reset by kaaaaaaang.
  • 2023-08-25 10:31:56.057719898 +0000 UTC m=+1491080.606735870: ☑️ agreed by kaaaaaaang.

@ti-chi-bot ti-chi-bot bot merged commit 78092c0 into pingcap:master Aug 25, 2023
4 checks passed
@kaaaaaaang kaaaaaaang added this to the 1.13.0 milestone Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants