update tidbver.TiDBSupportUpgradeAPI #2289
Conversation
ti-chi-bot
bot
added
the
size/XS
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2289 +/- ##
==========================================
- Coverage 55.87% 55.85% -0.02%
==========================================
Files 324 324
Lines 34164 34164
==========================================
- Hits 19087 19079 -8
- Misses 12799 12808 +9
+ Partials 2278 2277 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
|
@zimulala: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| @@ -28,7 +28,9 @@ func TiDBSupportSecureBoot(version string) bool { | |||
|
|
|||
| // TiDBSupportUpgradeAPI return if given version of TiDB support upgrade API | |||
| func TiDBSupportUpgradeAPI(version string) bool { | |||
| return semver.Compare(version, "v7.4.0") >= 0 || strings.Contains(version, "nightly") | |||
| return semver.Compare(version, "v7.4.0") >= 0 || | |||
| (semver.MajorMinor(version) == "v7.1" && semver.Compare(version, "v7.1.2") >= 0) || | |||
There was a problem hiding this comment.
Oh, probably not.
For example, upgrade from v7.1.2 to v7.4. However v7.4 does not support the upgrade function.
ti-chi-bot
bot
added
size/S
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
|
@kaaaaaaang: you cannot LGTM your own PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What problem does this PR solve?
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: