-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use port to probe db in playground #2296
use port to probe db in playground #2296
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2296 +/- ##
==========================================
- Coverage 55.54% 55.53% -0.01%
==========================================
Files 326 326
Lines 34421 34413 -8
==========================================
- Hits 19117 19109 -8
Misses 13022 13022
Partials 2282 2282
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
New changes are detected. LGTM label has been removed. |
What problem does this PR solve?
Close #2221
What is changed and how it works?
Use port not root user to probe db in playground.
Check List
Tests
Create a tidb configuration that contains init SQL to init root password.
Execute
tiup playground --db.config tidb.toml
.Connect db with password successfully.
Code changes
Side effects
Related changes
Release notes: