-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: fix tiproxy config and version #2354
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
I do not think it is a good idea to use nightly by default in tiup-cluster. For example,user may use tiup-cluster v1.14.1 years later. |
Signed-off-by: xhe <xw897002528@gmail.com>
Addressed. Fallback to |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2354 +/- ##
==========================================
- Coverage 55.53% 55.31% -0.22%
==========================================
Files 329 329
Lines 34836 34841 +5
==========================================
- Hits 19344 19270 -74
- Misses 13179 13258 +79
Partials 2313 2313
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
1,
require-backend-tls
is useless2. now we use
nightly
version by default3. fix a bug where configs are lost
Check List
Tests
Code changes
Side effects
Related changes
Release notes: