Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix tiproxy config and version #2354

Merged
merged 2 commits into from
Jan 9, 2024
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 8, 2024

What problem does this PR solve?

1, require-backend-tls is useless
2. now we use nightly version by default
3. fix a bug where configs are lost

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from breezewish January 8, 2024 12:44
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 8, 2024
@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Jan 8, 2024
@kaaaaaaang
Copy link
Collaborator

kaaaaaaang commented Jan 8, 2024

I do not think it is a good idea to use nightly by default in tiup-cluster. For example,user may use tiup-cluster v1.14.1 years later.

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 9, 2024
@xhebox
Copy link
Collaborator Author

xhebox commented Jan 9, 2024

I do not think it is a good idea to use nightly by default in tiup-cluster. For example,user may use tiup-cluster v1.14.1 years later.

Addressed. Fallback to "" by default. Or "nightly", if either component version or cluster version is.

@codecov-commenter
Copy link

codecov-commenter commented Jan 9, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (1210bc2) 55.53% compared to head (baa7cac) 55.31%.

❗ Current head baa7cac differs from pull request most recent head 0470547. Consider uploading reports for the commit 0470547 to get more accurate results

Files Patch % Lines
pkg/cluster/spec/tiproxy.go 50.00% 3 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2354      +/-   ##
==========================================
- Coverage   55.53%   55.31%   -0.22%     
==========================================
  Files         329      329              
  Lines       34836    34841       +5     
==========================================
- Hits        19344    19270      -74     
- Misses      13179    13258      +79     
  Partials     2313     2313              
Flag Coverage Δ
cluster 44.63% <50.00%> (-0.25%) ⬇️
dm 25.45% <0.00%> (-0.04%) ⬇️
playground 15.36% <0.00%> (-0.01%) ⬇️
tiup 33.59% <ø> (ø)
unittest 22.34% <0.00%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-09 06:24:47.467723656 +0000 UTC m=+338077.051977328: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 9, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3b246a3 into pingcap:master Jan 9, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants