-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster/tiflash: Remove deprecated config items #2357
base: master
Are you sure you want to change the base?
cluster/tiflash: Remove deprecated config items #2357
Conversation
Signed-off-by: JaySon-Huang <tshent@qq.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2357 +/- ##
==========================================
- Coverage 55.43% 55.39% -0.05%
==========================================
Files 329 329
Lines 34841 34848 +7
==========================================
- Hits 19314 19302 -12
- Misses 13216 13235 +19
Partials 2311 2311
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
c63a1ad
to
9b9a153
Compare
9b9a153
to
fbe2708
Compare
What problem does this PR solve?
What is changed and how it works?
default_profile
/display_name
/tmp_path
is no longer need since v5.4.0 (modify tiflash default config tiflash#3414)flash.flash_cluster
is no longer need since v6.0.0 (ddl: Move TiFlash cluster manager module into TiDB tidb#29924)Check List
Tests
Code changes
Side effects
Related changes
Release notes: