Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster/tiflash: Remove deprecated config items #2357

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JaySon-Huang
Copy link
Contributor

What problem does this PR solve?

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: JaySon-Huang <tshent@qq.com>
Copy link
Contributor

ti-chi-bot bot commented Jan 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from nexustar January 10, 2024 06:09
@JaySon-Huang JaySon-Huang marked this pull request as draft January 10, 2024 06:09
@ti-chi-bot ti-chi-bot bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b246a3) 55.43% compared to head (12e12af) 55.39%.

❗ Current head 12e12af differs from pull request most recent head fbe2708. Consider uploading reports for the commit fbe2708 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2357      +/-   ##
==========================================
- Coverage   55.43%   55.39%   -0.05%     
==========================================
  Files         329      329              
  Lines       34841    34848       +7     
==========================================
- Hits        19314    19302      -12     
- Misses      13216    13235      +19     
  Partials     2311     2311              
Flag Coverage Δ
cluster 44.71% <96.55%> (-0.04%) ⬇️
dm 25.44% <0.00%> (-0.01%) ⬇️
playground 15.37% <0.00%> (+<0.01%) ⬆️
tiup 33.59% <ø> (-0.05%) ⬇️
unittest 22.36% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JaySon-Huang JaySon-Huang force-pushed the flash_remove_cluster_manager_conf branch from c63a1ad to 9b9a153 Compare January 10, 2024 07:00
@JaySon-Huang JaySon-Huang force-pushed the flash_remove_cluster_manager_conf branch from 9b9a153 to fbe2708 Compare January 10, 2024 08:02
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Jan 11, 2024
@kaaaaaaang kaaaaaaang modified the milestones: v1.15.0, v1.17.0 Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants