Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster: fix tiproxy will restart even if version is the same #2358

Merged
merged 6 commits into from
Jan 12, 2024

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 10, 2024

What problem does this PR solve?

Restart tiproxy iff version becomes different after --tiproxyversion or new cluster version(only nightly is possible though).

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from breezewish January 10, 2024 06:26
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 10, 2024

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (0c6dda9) 55.40% compared to head (0bc8dd9) 55.44%.
Report is 2 commits behind head on master.

❗ Current head 0bc8dd9 differs from pull request most recent head 6a4c5d4. Consider uploading reports for the commit 6a4c5d4 to get more accurate results

Files Patch % Lines
components/playground/instance/tiflash.go 7.14% 26 Missing ⚠️
components/playground/instance/tiflash_config.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2358      +/-   ##
==========================================
+ Coverage   55.40%   55.44%   +0.05%     
==========================================
  Files         329      329              
  Lines       34845    34849       +4     
==========================================
+ Hits        19304    19322      +18     
+ Misses      13232    13214      -18     
- Partials     2309     2313       +4     
Flag Coverage Δ
cluster 44.76% <100.00%> (+0.04%) ⬆️
dm 25.53% <100.00%> (+0.03%) ⬆️
playground 15.37% <6.90%> (-0.01%) ⬇️
tiup 33.60% <ø> (-0.05%) ⬇️
unittest 22.33% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang changed the title cluster: skip tiproxy restart iff version is same cluster: skip tiproxy restart if version is same Jan 11, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 11, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jan 11, 2024
@kaaaaaaang
Copy link
Collaborator

/hold

@ti-chi-bot ti-chi-bot bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed lgtm labels Jan 11, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 11, 2024

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 11, 2024
Signed-off-by: xhe <xw897002528@gmail.com>
@kaaaaaaang kaaaaaaang changed the title cluster: skip tiproxy restart if version is same cluster: skip tiproxy restart if version is the same Jan 11, 2024
@kaaaaaaang kaaaaaaang changed the title cluster: skip tiproxy restart if version is the same cluster: fix tiproxy will restart even if version is the same Jan 11, 2024
@kaaaaaaang kaaaaaaang added this to the v1.14.1 milestone Jan 11, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 12, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 12, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 12, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-11 08:03:37.249241169 +0000 UTC m=+516806.833494855: ☑️ agreed by kaaaaaaang.
  • 2024-01-11 08:03:53.315621976 +0000 UTC m=+516822.899875652: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-01-12 09:49:10.010190593 +0000 UTC m=+609539.594444280: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kaaaaaaang kaaaaaaang removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 12, 2024
@ti-chi-bot ti-chi-bot bot merged commit c618054 into pingcap:master Jan 12, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants