-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: set tiproxy addr without schema #2368
Conversation
Signed-off-by: xhe <xw897002528@gmail.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2368 +/- ##
=======================================
Coverage 55.76% 55.76%
=======================================
Files 329 329
Lines 35024 35024
=======================================
Hits 19531 19531
Misses 13149 13149
Partials 2344 2344
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/lgtm |
/approve |
@xhebox: Your PR was out of date, I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
If user sets TLS for PD endpoints, then tiproxy or etcd/client/v3 is not able to use TLS since
http://...
is passed to etcd client. Check https://github.com/etcd-io/etcd/blob/main/client/v3/internal/endpoint/endpoint.go#L90-L118. However, when onlyhost:port
is passed, the TLS config will be used.Check List
Tests
Code changes
Side effects
Related changes
Release notes: