Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: set tiproxy addr without schema #2368

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

xhebox
Copy link
Collaborator

@xhebox xhebox commented Jan 23, 2024

What problem does this PR solve?

If user sets TLS for PD endpoints, then tiproxy or etcd/client/v3 is not able to use TLS since http://... is passed to etcd client. Check https://github.com/etcd-io/etcd/blob/main/client/v3/internal/endpoint/endpoint.go#L90-L118. However, when only host:port is passed, the TLS config will be used.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: xhe <xw897002528@gmail.com>
@ti-chi-bot ti-chi-bot bot requested a review from nexustar January 23, 2024 07:09
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (c72f4e0) 55.76% compared to head (76a0297) 55.76%.

❗ Current head 76a0297 differs from pull request most recent head 891f79e. Consider uploading reports for the commit 891f79e to get more accurate results

Files Patch % Lines
components/playground/instance/tiproxy.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2368   +/-   ##
=======================================
  Coverage   55.76%   55.76%           
=======================================
  Files         329      329           
  Lines       35024    35024           
=======================================
  Hits        19531    19531           
  Misses      13149    13149           
  Partials     2344     2344           
Flag Coverage Δ
playground 15.34% <0.00%> (+0.01%) ⬆️
tiup 33.60% <ø> (ø)
unittest 22.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Jan 31, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 31, 2024
@kaaaaaaang
Copy link
Collaborator

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Jan 31, 2024
@ti-chi-bot ti-chi-bot bot removed the lgtm label Jan 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

@xhebox: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@kaaaaaaang
Copy link
Collaborator

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Jan 31, 2024
Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-01-31 03:27:07.902101216 +0000 UTC m=+1536069.466398922: ☑️ agreed by kaaaaaaang.
  • 2024-01-31 07:16:39.33685722 +0000 UTC m=+1549840.901154920: ✖️🔁 reset by ti-chi-bot[bot].
  • 2024-01-31 07:59:24.857260746 +0000 UTC m=+1552406.421558450: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Jan 31, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 79c584f into pingcap:master Jan 31, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants