Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: Add tidb-cse mode #2386

Merged
merged 5 commits into from
Mar 27, 2024
Merged

playground: Add tidb-cse mode #2386

merged 5 commits into from
Mar 27, 2024

Conversation

breezewish
Copy link
Member

What problem does this PR solve?

Remove tidb-disagg, and add tidb-cse.

What is changed and how it works?

tidb-cse mode is used to start a TiDB CSE cluster, it contains disaggregated TiFlash and TiKV in CSE mode.

Check List

Tests

  • Manual test

Release notes:

playground: Support --mode=tidb-cse

Signed-off-by: Wish <breezewish@outlook.com>
@ti-chi-bot ti-chi-bot bot requested a review from srstack March 20, 2024 06:22
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 20, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 20, 2024

Codecov Report

Attention: Patch coverage is 0% with 40 lines in your changes are missing coverage. Please review.

Project coverage is 55.87%. Comparing base (ddbbc4d) to head (ef71b3d).

❗ Current head ef71b3d differs from pull request most recent head 6018b89. Consider uploading reports for the commit 6018b89 to get more accurate results

Files Patch % Lines
components/playground/playground.go 0.00% 25 Missing ⚠️
components/playground/main.go 0.00% 15 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2386      +/-   ##
==========================================
- Coverage   56.01%   55.87%   -0.14%     
==========================================
  Files         329      329              
  Lines       35154    35127      -27     
==========================================
- Hits        19688    19624      -64     
- Misses      13113    13154      +41     
+ Partials     2353     2349       -4     
Flag Coverage Δ
cluster 45.17% <ø> (-0.13%) ⬇️
dm 25.49% <ø> (+<0.01%) ⬆️
tiup 33.59% <ø> (ø)
unittest 22.16% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Wish <breezewish@outlook.com>
@kaaaaaaang
Copy link
Collaborator

Please resolve conflicts

Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
@breezewish
Copy link
Member Author

Fixed, PTAL again, thanks!

@kaaaaaaang
Copy link
Collaborator

please fix it again :)

Signed-off-by: Wish <breezewish@outlook.com>
@breezewish
Copy link
Member Author

Fixed again~

@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 27, 2024
Copy link
Collaborator

@kaaaaaaang kaaaaaaang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the lgtm label Mar 27, 2024
Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-27 16:44:17.809739173 +0000 UTC m=+2086284.831985571: ☑️ agreed by kaaaaaaang.

@kaaaaaaang
Copy link
Collaborator

/approve

Copy link
Contributor

ti-chi-bot bot commented Mar 27, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaaaaaaang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 27, 2024
@ti-chi-bot ti-chi-bot bot merged commit b9aa9de into master Mar 27, 2024
19 checks passed
@ti-chi-bot ti-chi-bot bot deleted the wenxuan/cse-mode branch March 27, 2024 16:45
@kaaaaaaang kaaaaaaang added this to the v1.15.0 milestone Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants