-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: Add tidb-cse mode #2386
Conversation
Signed-off-by: Wish <breezewish@outlook.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2386 +/- ##
==========================================
- Coverage 56.01% 55.87% -0.14%
==========================================
Files 329 329
Lines 35154 35127 -27
==========================================
- Hits 19688 19624 -64
- Misses 13113 13154 +41
+ Partials 2353 2349 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Please resolve conflicts |
Signed-off-by: Wish <breezewish@outlook.com>
Signed-off-by: Wish <breezewish@outlook.com>
Fixed, PTAL again, thanks! |
please fix it again :) |
Signed-off-by: Wish <breezewish@outlook.com>
Fixed again~ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[LGTM Timeline notifier]Timeline:
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaaaaaaang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What problem does this PR solve?
Remove tidb-disagg, and add tidb-cse.
What is changed and how it works?
tidb-cse mode is used to start a TiDB CSE cluster, it contains disaggregated TiFlash and TiKV in CSE mode.
Check List
Tests
Release notes: