-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground/pdms: wait for tso component ready #2394
Conversation
Signed-off-by: husharp <jinhao.hu@pingcap.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2394 +/- ##
==========================================
- Coverage 55.81% 50.50% -5.31%
==========================================
Files 329 329
Lines 35222 35258 +36
==========================================
- Hits 19657 17805 -1852
- Misses 13200 15303 +2103
+ Partials 2365 2150 -215
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pkg/cluster/api/pdapi.go
Outdated
@@ -139,6 +139,7 @@ var ( | |||
pdStoresURI = "pd/api/v1/stores" | |||
pdStoresLimitURI = "pd/api/v1/stores/limit" | |||
pdRegionsCheckURI = "pd/api/v1/regions/check" | |||
pdMSHealthPrefix = "api/v1/health" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pdMSHealthPrefix = "api/v1/health" | |
pdMSHealthPrefix = "tso/api/v1/health" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rest LGTM
@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: husharp <jinhao.hu@pingcap.com>
please fix the UT |
Fixed. But not sure why get |
/lgtm |
[LGTM Timeline notifier]Timeline:
|
/found community |
1 similar comment
/found community |
What problem does this PR solve?
Close #2396
What is changed and how it works?
can reload cluster with tag
Check List
Tests
Code changes
Side effects
Related changes
Release notes: