Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground/pdms: wait for tso component ready #2394

Merged
merged 3 commits into from
Apr 9, 2024

Conversation

HuSharp
Copy link
Contributor

@HuSharp HuSharp commented Apr 1, 2024

What problem does this PR solve?

Close #2396

What is changed and how it works?

can reload cluster with tag
image

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No cod

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Signed-off-by: husharp <jinhao.hu@pingcap.com>
Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kaaaaaaang for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from nexustar and srstack April 1, 2024 09:35
@ti-chi-bot ti-chi-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 1, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 35 lines in your changes are missing coverage. Please review.

Project coverage is 50.50%. Comparing base (48f15f4) to head (c4558b2).
Report is 1 commits behind head on master.

❗ Current head c4558b2 differs from pull request most recent head a7a3cbf. Consider uploading reports for the commit a7a3cbf to get more accurate results

Files Patch % Lines
pkg/cluster/api/pdapi.go 0.00% 20 Missing ⚠️
components/playground/instance/tikv.go 30.00% 13 Missing and 1 partial ⚠️
components/playground/playground.go 50.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2394      +/-   ##
==========================================
- Coverage   55.81%   50.50%   -5.31%     
==========================================
  Files         329      329              
  Lines       35222    35258      +36     
==========================================
- Hits        19657    17805    -1852     
- Misses      13200    15303    +2103     
+ Partials     2365     2150     -215     
Flag Coverage Δ
cluster 36.03% <0.00%> (-9.07%) ⬇️
playground 16.36% <16.67%> (-0.01%) ⬇️
tiup 33.59% <ø> (ø)
unittest 22.15% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -139,6 +139,7 @@ var (
pdStoresURI = "pd/api/v1/stores"
pdStoresLimitURI = "pd/api/v1/stores/limit"
pdRegionsCheckURI = "pd/api/v1/regions/check"
pdMSHealthPrefix = "api/v1/health"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pdMSHealthPrefix = "api/v1/health"
pdMSHealthPrefix = "tso/api/v1/health"

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

Copy link
Contributor

ti-chi-bot bot commented Apr 1, 2024

@rleungx: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

The rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@kaaaaaaang
Copy link
Collaborator

please fix the UT

Signed-off-by: husharp <jinhao.hu@pingcap.com>
@HuSharp
Copy link
Contributor Author

HuSharp commented Apr 3, 2024

please fix the UT

Fixed. But not sure why get [ERROR] Please install docker-compose in integrate-cluster-cmd :(

@kaaaaaaang kaaaaaaang added this to the v1.15.1 milestone Apr 9, 2024
@kaaaaaaang
Copy link
Collaborator

/lgtm

@kaaaaaaang kaaaaaaang merged commit 11f6005 into pingcap:master Apr 9, 2024
18 of 19 checks passed
@ti-chi-bot ti-chi-bot bot added the lgtm label Apr 9, 2024
Copy link
Contributor

ti-chi-bot bot commented Apr 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-04-09 12:17:48.71737495 +0000 UTC m=+964730.244915493: ☑️ agreed by kaaaaaaang.

@HuSharp HuSharp deleted the wait_for_tso branch April 9, 2024 12:18
@seiya-annie
Copy link

/found community

1 similar comment
@seiya-annie
Copy link

/found community

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tiup playground fail to restart pdms cluster
5 participants