Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "pdms(playground, cluster): add name to start pdms" #2446

Merged
merged 1 commit into from
Jul 30, 2024

Conversation

kaaaaaaang
Copy link
Collaborator

Reverts #2438

Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign xhebox for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested a review from nexustar July 30, 2024 08:08
@ti-chi-bot ti-chi-bot bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jul 30, 2024
Copy link
Contributor

ti-chi-bot bot commented Jul 30, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-30 08:09:24.709689843 +0000 UTC m=+256880.989737912: ☑️ agreed by xhebox.

@ti-chi-bot ti-chi-bot bot added the lgtm label Jul 30, 2024
@kaaaaaaang kaaaaaaang merged commit 61c9724 into master Jul 30, 2024
4 of 20 checks passed
@kaaaaaaang kaaaaaaang deleted the revert-2438-add_name_to_pdms branch July 30, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants