Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix custom config of grafana #535

Merged
merged 2 commits into from
Jun 28, 2020
Merged

Fix custom config of grafana #535

merged 2 commits into from
Jun 28, 2020

Conversation

july2993
Copy link
Contributor

@july2993 july2993 commented Jun 24, 2020

fix #534 also, for Prometheus, listen on the specified host.
we call GetFreePort with the specified host.

Note that we can listen on both "0.0.0.0" and some specified ip like "127.0.0.1"

also, for prometheus, listen on the specified host.
we call GetFreePort with the specified host.

Node we can listen on both "0.0.0.0" and some specified ip like "127.0.0.1"
@CLAassistant
Copy link

CLAassistant commented Jun 24, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2020

Codecov Report

Merging #535 into master will increase coverage by 11.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master     #535       +/-   ##
===========================================
+ Coverage   39.84%   50.93%   +11.08%     
===========================================
  Files         201      220       +19     
  Lines       14847    15877     +1030     
===========================================
+ Hits         5916     8087     +2171     
+ Misses       8072     6688     -1384     
- Partials      859     1102      +243     
Flag Coverage Δ
#coverage 50.93% <ø> (+11.08%) ⬆️
Impacted Files Coverage Δ
...o/src/github.com/pingcap/tiup/server/store/sync.go 28.57% <0.00%> (-28.58%) ⬇️
....com/pingcap/tiup/pkg/cluster/clusterutil/retry.go 50.00% <0.00%> (-17.50%) ⬇️
go/src/github.com/pingcap/tiup/cmd/mirror.go 39.95% <0.00%> (-6.89%) ⬇️
...ingcap/tiup/components/playground/instance/tidb.go 85.36% <0.00%> (-5.34%) ⬇️
...ingcap/tiup/components/playground/instance/tikv.go 75.00% <0.00%> (-4.32%) ⬇️
...cap/tiup/components/playground/instance/tiflash.go 59.67% <0.00%> (-4.11%) ⬇️
go/src/github.com/pingcap/tiup/cmd/root.go 60.43% <0.00%> (-3.85%) ⬇️
...om/pingcap/tiup/components/cluster/command/root.go 43.03% <0.00%> (-2.24%) ⬇️
...m/pingcap/tiup/components/playground/playground.go 26.70% <0.00%> (-1.91%) ⬇️
.../pingcap/tiup/components/playground/instance/pd.go 75.43% <0.00%> (-1.23%) ⬇️
... and 113 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ab50de...2a3366f. Read the comment docs.

@july2993 july2993 added the status/can-merge Indicates a PR has been approved by a committer. label Jun 25, 2020
@july2993 july2993 merged commit b60a1f2 into pingcap:master Jun 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

playground: grafana can't start when port 3000 is token
4 participants