-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
playground: fix panic if failed to start tiflash #543
Conversation
Codecov Report
@@ Coverage Diff @@
## master #543 +/- ##
===========================================
+ Coverage 39.84% 50.98% +11.14%
===========================================
Files 201 220 +19
Lines 14847 15914 +1067
===========================================
+ Hits 5916 8114 +2198
+ Misses 8072 6693 -1379
- Partials 859 1107 +248
Continue to review full report at Codecov.
|
@lonng PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/merge |
Fix #538
We always
Wait
the instances before, if it failed to start it will panic caused the Command is not initialized and started.This PR make sure it only
Wait
the instance iff it's started successfully.