-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cluster: show message for impossible fix #550
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #550 +/- ##
===========================================
+ Coverage 39.84% 50.92% +11.08%
===========================================
Files 201 220 +19
Lines 14847 15875 +1028
===========================================
+ Hits 5916 8085 +2169
+ Misses 8072 6688 -1384
- Partials 859 1102 +243
Continue to review full report at Codecov.
|
hhkbp2
force-pushed
the
show-impossible-fix
branch
from
June 29, 2020 06:17
b92e0fd
to
dd37618
Compare
AstroProfundis
approved these changes
Jun 29, 2020
AstroProfundis
added
status/can-merge
Indicates a PR has been approved by a committer.
type/enhancement
Categorizes issue or PR as related to an enhancement.
labels
Jun 29, 2020
/run-all-tests |
@hhkbp2 merge failed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
status/can-merge
Indicates a PR has been approved by a committer.
type/enhancement
Categorizes issue or PR as related to an enhancement.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR fixes issue #335
What is changed and how it works?
Add message for failed checking result that's impossible to fix by
tiup cluster check --apply
, for better user experience.Check List
Tests
Code changes
Side effects
Related changes