Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle yanked version in update #635

Merged
merged 13 commits into from
Jul 30, 2020
Merged

Conversation

lucklove
Copy link
Member

Fix #177

Signed-off-by: lucklove gnu.crazier@gmail.com

Fix pingcap#177

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove added the type/bug-fix Categorizes PR as a bug-fix label Jul 28, 2020
@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2020

Codecov Report

Merging #635 into master will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #635      +/-   ##
==========================================
+ Coverage   47.38%   47.48%   +0.10%     
==========================================
  Files         227      227              
  Lines       17137    17142       +5     
==========================================
+ Hits         8120     8140      +20     
+ Misses       7914     7894      -20     
- Partials     1103     1108       +5     
Flag Coverage Δ
#coverage 47.48% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 53.65% <0.00%> (-1.22%) ⬇️
...b.com/pingcap/tiup/pkg/repository/v1_repository.go 66.75% <0.00%> (+0.42%) ⬆️
...m/pingcap/tiup/components/playground/playground.go 30.33% <0.00%> (+0.96%) ⬆️
go/src/github.com/pingcap/tiup/pkg/utils/ioutil.go 47.54% <0.00%> (+10.65%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2760151...dfb7468. Read the comment docs.

tests/tiup/tiup.toml Outdated Show resolved Hide resolved
lucklove and others added 4 commits July 28, 2020 17:21
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
lucklove and others added 2 commits July 30, 2020 15:00
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Co-authored-by: Lonng <heng@lonng.org>
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 30, 2020
@lonng
Copy link
Contributor

lonng commented Jul 30, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Jul 30, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lucklove merge failed.

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lonng lonng merged commit b3a5326 into pingcap:master Jul 30, 2020
@lonng lonng deleted the update-yanked branch July 30, 2020 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tiup should ignore deprecated components
4 participants