Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix: cleanup wrong conf files #738

Merged
merged 5 commits into from
Sep 1, 2020
Merged

Conversation

lucklove
Copy link
Member

@lucklove lucklove commented Sep 1, 2020

Fix #736

Signed-off-by: lucklove gnu.crazier@gmail.com

Fix pingcap#736

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Fix pingcap#735

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Fix pingcap#731

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 1, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2020

Codecov Report

Merging #738 into master will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #738      +/-   ##
==========================================
- Coverage   58.09%   58.05%   -0.05%     
==========================================
  Files         255      255              
  Lines       18902    18904       +2     
==========================================
- Hits        10982    10974       -8     
- Misses       6469     6475       +6     
- Partials     1451     1455       +4     
Flag Coverage Δ
#coverage 58.05% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/github.com/pingcap/tiup/pkg/cluster/api/pdapi.go 53.65% <0.00%> (-2.44%) ⬇️
....com/pingcap/tiup/pkg/cluster/spec/alertmanager.go 62.29% <0.00%> (-2.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfed19f...2996cb2. Read the comment docs.

@lucklove lucklove merged commit 30c63e6 into pingcap:master Sep 1, 2020
@lucklove lucklove deleted the cleanup-conf branch September 1, 2020 12:22
lucklove added a commit that referenced this pull request Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.1.0: cleanup shared conf directory by mistake
4 participants