-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dependences version binding when cloning mirror #779
Conversation
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #779 +/- ##
==========================================
- Coverage 54.57% 49.09% -5.49%
==========================================
Files 261 258 -3
Lines 21142 21004 -138
==========================================
- Hits 11538 10311 -1227
- Misses 8052 9246 +1194
+ Partials 1552 1447 -105
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Can we use the latest version of tispark by default? |
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
Currently, if the versions of the non-core components not specified, the latest version will be chosen. The behavior will abort the
tiup cluster deploy
because it binds version to a specific version totispark/spark
.This PR fixes dependences version binding when cloning mirrors.
Release notes: