Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dependences version binding when cloning mirror #779

Merged
merged 11 commits into from
Sep 16, 2020

Conversation

lucklove
Copy link
Member

What problem does this PR solve?

Currently, if the versions of the non-core components not specified, the latest version will be chosen. The behavior will abort the tiup cluster deploy because it binds version to a specific version to tispark/spark.

This PR fixes dependences version binding when cloning mirrors.

Release notes:

Fix dependences version binding when cloning mirror

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove added the type/bug-fix Categorizes PR as a bug-fix label Sep 13, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 13, 2020

Codecov Report

Merging #779 into master will decrease coverage by 5.48%.
The diff coverage is 61.76%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
- Coverage   54.57%   49.09%   -5.49%     
==========================================
  Files         261      258       -3     
  Lines       21142    21004     -138     
==========================================
- Hits        11538    10311    -1227     
- Misses       8052     9246    +1194     
+ Partials     1552     1447     -105     
Flag Coverage Δ
#cluster 44.93% <64.61%> (-1.93%) ⬇️
#dm 26.91% <27.69%> (-0.02%) ⬇️
#integrate 49.09% <61.76%> (-0.78%) ⬇️
#playground 22.96% <65.21%> (+0.04%) ⬆️
#tiup 11.29% <57.69%> (-8.51%) ⬇️
#unittest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cmd/mirror.go 39.67% <0.00%> (-0.19%) ⬇️
pkg/cluster/spec/bindversion.go 84.21% <ø> (-2.75%) ⬇️
pkg/repository/clone_mirror.go 0.00% <0.00%> (ø)
pkg/cluster/manager.go 67.04% <35.29%> (-1.17%) ⬇️
pkg/cluster/task/copy_component.go 82.60% <66.66%> (-5.63%) ⬇️
pkg/cluster/task/download.go 78.94% <66.66%> (-5.67%) ⬇️
pkg/repository/v1manifest/key_store.go 50.00% <80.00%> (-16.67%) ⬇️
pkg/cluster/prepare.go 100.00% <100.00%> (ø)
pkg/cluster/task/builder.go 97.09% <100.00%> (-0.02%) ⬇️
pkg/repository/v1manifest/local_manifests.go 37.29% <100.00%> (-3.79%) ⬇️
... and 46 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7505ae...42479c4. Read the comment docs.

@lonng
Copy link
Contributor

lonng commented Sep 14, 2020

Can we use the latest version of tispark by default?

Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
pkg/cluster/prepare.go Outdated Show resolved Hide resolved
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Signed-off-by: lucklove <gnu.crazier@gmail.com>
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 16, 2020
@lucklove lucklove merged commit 169e7cb into pingcap:master Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/bug-fix Categorizes PR as a bug-fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants