Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support config core dump limit #817

Merged
merged 2 commits into from
Sep 27, 2020
Merged

Support config core dump limit #817

merged 2 commits into from
Sep 27, 2020

Conversation

lucklove
Copy link
Member

Fix #540

Signed-off-by: lucklove gnu.crazier@gmail.com

What problem does this PR solve?

#540

What is changed and how it works?

Add LimitCORE in service.tpl

Check List

Tests

  • Manual test (add detailed scripts or steps below)

屏幕快照 2020-09-25 下午8 48 10

屏幕快照 2020-09-25 下午8 48 31

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

Fix pingcap#540

Signed-off-by: lucklove <gnu.crazier@gmail.com>
@lucklove lucklove self-assigned this Sep 25, 2020
@codecov-commenter
Copy link

codecov-commenter commented Sep 25, 2020

Codecov Report

Merging #817 into master will increase coverage by 3.96%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #817      +/-   ##
==========================================
+ Coverage   48.65%   52.62%   +3.96%     
==========================================
  Files         262      262              
  Lines       18850    18855       +5     
==========================================
+ Hits         9172     9922     +750     
+ Misses       8221     7383     -838     
- Partials     1457     1550      +93     
Flag Coverage Δ
#cluster 44.72% <66.66%> (+5.69%) ⬆️
#dm 25.33% <66.66%> (-0.01%) ⬇️
#integrate 47.78% <66.66%> (+4.00%) ⬆️
#playground 22.22% <ø> (ø)
#tiup 10.92% <16.66%> (-0.01%) ⬇️
#unittest 18.56% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/instance.go 65.11% <33.33%> (-0.76%) ⬇️
pkg/cluster/embed/autogen_pkger.go 100.00% <100.00%> (ø)
pkg/cluster/template/systemd/system.go 73.33% <100.00%> (+1.90%) ⬆️
pkg/cluster/spec/tispark.go 67.39% <0.00%> (+1.08%) ⬆️
pkg/cluster/operation/action.go 51.51% <0.00%> (+1.86%) ⬆️
pkg/cluster/spec/spec.go 89.65% <0.00%> (+3.44%) ⬆️
pkg/cliutil/cliutil.go 67.85% <0.00%> (+5.35%) ⬆️
pkg/cluster/task/install_package.go 53.33% <0.00%> (+6.66%) ⬆️
pkg/cluster/manager.go 66.66% <0.00%> (+6.96%) ⬆️
pkg/cluster/task/ssh_keygen.go 65.30% <0.00%> (+8.16%) ⬆️
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfab8de...345c653. Read the comment docs.

@lonng lonng added this to the v1.2.0 milestone Sep 26, 2020
Copy link
Contributor

@lonng lonng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Sep 26, 2020
@lonng
Copy link
Contributor

lonng commented Sep 26, 2020

/merge

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Sep 26, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot
Copy link
Contributor

@lucklove merge failed.

@lonng lonng removed the status/PTAL label Sep 26, 2020
@lucklove lucklove merged commit c7fbf19 into pingcap:master Sep 27, 2020
@lucklove lucklove deleted the core-dump branch September 27, 2020 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option to enable core dump
4 participants