-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce a more graceful way to check labels #843
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pingcap#838 Signed-off-by: lucklove <gnu.crazier@gmail.com>
Codecov Report
@@ Coverage Diff @@
## master #843 +/- ##
==========================================
+ Coverage 52.99% 53.10% +0.11%
==========================================
Files 261 261
Lines 18987 19014 +27
==========================================
+ Hits 10062 10098 +36
+ Misses 7367 7357 -10
- Partials 1558 1559 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AstroProfundis
approved these changes
Oct 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #838
Signed-off-by: lucklove gnu.crazier@gmail.com
What problem does this PR solve?
For imported clusters, it will report missing label when executing
tiup cluster display
since the server.labels is missing in meta.yaml.What is changed and how it works?
Read labels config from PD server instead of meta.yaml.
Check List
Tests
Related changes
Release notes: