-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dataDir not deleted if containing comma #871
Conversation
Codecov Report
@@ Coverage Diff @@
## master #871 +/- ##
==========================================
- Coverage 53.04% 49.42% -3.63%
==========================================
Files 263 263
Lines 19030 19042 +12
==========================================
- Hits 10095 9412 -683
- Misses 7374 8145 +771
+ Partials 1561 1485 -76
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, some tests need to be fixed
be3084b
to
e032ead
Compare
c3ee191
to
6041116
Compare
Fixed, and PTAL |
/merge |
/run-all-tests |
* typo(cluster): naming * cluster/spec: countdir should split dir if ',' seplit * cluster/spec: dirConflict split data_dir * tests/tiup-cluster: add case of tiflash scale-in/out with multi dir * cluster/spec: trim dataDir's space before count Co-authored-by: ti-srebot <66930949+ti-srebot@users.noreply.github.com>
What problem does this PR solve?
fix #865
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: