-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cluster/audit): compatible with old second based ts #882
fix(cluster/audit): compatible with old second based ts #882
Conversation
Codecov Report
@@ Coverage Diff @@
## master #882 +/- ##
==========================================
+ Coverage 53.26% 53.33% +0.06%
==========================================
Files 263 263
Lines 19042 19047 +5
==========================================
+ Hits 10143 10158 +15
+ Misses 7321 7315 -6
+ Partials 1578 1574 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9d40deb
to
b530f29
Compare
b530f29
to
6139411
Compare
@lucklove It's curious why the Starting component dm-master
Starting instance dm-master 172.19.0.101:8261
retry error: operation timed out after 1m0s
dm-master 172.19.0.101:8261 failed to start: timed out waiting for port 8261 to be started after 1m0s, please check the log of the instance
Error: failed to start dm-master: dm-master 172.19.0.101:8261 failed to start: timed out waiting for port 8261 to be started after 1m0s, please check the log of the instance: timed out waiting for port 8261 to be started after 1m0s
Verbose debug logs has been written to /tiup-cluster/tests/tiup-dm/logs/tiup-cluster-debug-2020-11-03-16-56-18.log. and retry error: operation timed out after 2m0s
cdc 172.19.0.104:8300 failed to start: timed out waiting for port 8300 to be started after 2m0s, please check the log of the instance
Error: failed to start cdc: cdc 172.19.0.104:8300 failed to start: timed out waiting for port 8300 to be started after 2m0s, please check the log of the instance: timed out waiting for port 8300 to be started after 2m0s
Verbose debug logs has been written to /tiup-cluster/tests/tiup-cluster/logs/tiup-cluster-debug-2020-11-03-16-56-17.log. Seems the cluster's log is uploaded tiup/.github/workflows/integrate-cluster-scale.yaml Lines 74 to 80 in 871ae58
But I don't where the log is stored, so could you please help me to dig into those logs(if you know it). BTW, Seems there was no log inside tiup/.github/workflows/integrate-cluster-scale.yaml Lines 82 to 90 in 871ae58
IMO, we can |
You are right, it's due to the limited resource, we can just re-run these failed jobs this time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What problem does this PR solve?
The old audit's filename was based on
second
, after #879 merged, the filename changed tonanosecond
based. So this PR fixes the difference between those two situations.What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: