Fix imported pump & drainer start script

[lucklove]

Signed-off-by: lucklove gnu.crazier@gmail.com

What problem does this PR solve?

#797

What is changed and how it works?

• don't add --node-id flag for imported instance in start scripts (to avoid node-id change)
• fetch the real node id from pd(etcd) instead of hard coding one

Check List

Tests

• Manual test (add detailed scripts or steps below)
  • case 1
    • deploy a cluster with pump
    • modify the --node-id flag to anything others
    • modify meta.yaml and set imported: true for pump
    • try to scale-in that pump server
    • destroy the cluster
  • case 2
    • deploy a cluster with pump
    • modify meta.yaml and set imported: true for pump
    • reload cluster
    • the generated run_pump.sh should not contain --node-id flag
  • case 3
    • deploy a cluster with pump
    • scale-in pump

Related changes

• Need to cherry-pick to the release branch

Release notes:

NONE

[codecov-io]

Codecov Report

Merging #903 (dfe6b1f) into master (ffa217f) will decrease coverage by 26.91%.
The diff coverage is 5.26%.

@@             Coverage Diff             @@
##           master     #903       +/-   ##
===========================================
- Coverage   44.03%   17.11%   -26.92%     
===========================================
  Files         260      154      -106     
  Lines       18911    11700     -7211     
===========================================
- Hits         8328     2003     -6325     
- Misses       9291     9294        +3     
+ Partials     1292      403      -889     

Flag	Coverage Δ
cluster	?
dm	?
integrate	17.11% <5.26%> (-21.07%)	⬇️
playground	22.09% <0.00%> (-0.07%)	⬇️
tiup	10.67% <5.88%> (-0.04%)	⬇️
unittest	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
components/playground/playground.go	41.09% <0.00%> (ø)
pkg/cluster/api/binlog.go	0.00% <0.00%> (-15.74%)	⬇️
pkg/cluster/spec/drainer.go	0.00% <0.00%> (-59.58%)	⬇️
pkg/cluster/spec/pump.go	0.00% <0.00%> (-62.64%)	⬇️
pkg/cluster/embed/autogen_pkger.go	100.00% <100.00%> (ø)
pkg/meta/paths.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/utils/utils.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/utils/semver.go	0.00% <0.00%> (-100.00%)	⬇️
pkg/cluster/spec/validate.go	0.00% <0.00%> (-93.04%)	⬇️
pkg/telemetry/scrub.go	0.00% <0.00%> (-86.67%)	⬇️
... and 186 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffa217f...dfe6b1f. Read the comment docs.

[july2993]

better test with the clusters imported since this issue fixes those clusters.

[lucklove]

better test with the clusters imported since this issue fixes those clusters.

OK, I'm trying to deploy one with ansible, it's a little challenging...