Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node_exporter): add --collector.buddyinfo #904

Merged

Conversation

9547
Copy link
Contributor

@9547 9547 commented Nov 12, 2020

What problem does this PR solve?

implement #877

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 13, 2020
@lucklove
Copy link
Member

It seems that you changed the template file but forget to run make pkger. Please run make pkger and commit again.

@9547
Copy link
Contributor Author

9547 commented Nov 13, 2020

Thanks for the advice, and i think maybe we can use tools like pre-commit to automatical run make pkger to generate the pkg if those template files changed, before commit

@lucklove
Copy link
Member

Thanks for the advice, and i think maybe we can use tools like pre-commit to automatical run make pkger to generate the pkg if those template files changed, before commit

That's a good ideal, but it seems git hook only works on local, do you know is there anyway to run it in github server?

@9547
Copy link
Contributor Author

9547 commented Nov 13, 2020

Seems github didn't support git hooks, the only we can use is web hooks

@lucklove
Copy link
Member

Seems github didn't support git hooks, the only we can use is web hooks

Web hook can only do post-check, there is no need to add it since we have unit test to do it (and what I mean is that you should make pkger and push again to pass the unit test)

@9547 9547 force-pushed the feature/node_exporter-add-buddyinfo branch from a5859aa to 2e7572d Compare November 13, 2020 12:12
@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #904 (df68571) into master (cd971a5) will decrease coverage by 8.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #904      +/-   ##
==========================================
- Coverage   53.15%   45.11%   -8.05%     
==========================================
  Files         260      260              
  Lines       18909    18909              
==========================================
- Hits        10051     8530    -1521     
- Misses       7319     9048    +1729     
+ Partials     1539     1331     -208     
Flag Coverage Δ
cluster 32.99% <100.00%> (-12.20%) ⬇️
dm 24.62% <100.00%> (-0.43%) ⬇️
integrate 39.42% <100.00%> (-8.32%) ⬇️
playground 22.17% <ø> (ø)
tiup 10.70% <100.00%> (ø)
unittest 21.52% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/embed/autogen_pkger.go 100.00% <100.00%> (ø)
pkg/cluster/template/config/config.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/scripts.go 0.00% <0.00%> (-100.00%) ⬇️
pkg/cluster/template/scripts/tiflash.go 0.00% <0.00%> (-79.60%) ⬇️
components/cluster/command/check.go 6.37% <0.00%> (-72.82%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/template/systemd/tispark.go 0.00% <0.00%> (-68.00%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
pkg/cluster/template/scripts/tispark.go 0.00% <0.00%> (-65.00%) ⬇️
pkg/cluster/spec/tiflash.go 2.11% <0.00%> (-64.84%) ⬇️
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd971a5...df68571. Read the comment docs.

@AstroProfundis AstroProfundis merged commit f9591eb into pingcap:master Nov 17, 2020
@lucklove lucklove added this to the v1.3.0 milestone Dec 17, 2020
@9547 9547 deleted the feature/node_exporter-add-buddyinfo branch April 6, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants