-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(node_exporter): add --collector.buddyinfo #904
feat(node_exporter): add --collector.buddyinfo #904
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It seems that you changed the template file but forget to run |
Thanks for the advice, and i think maybe we can use tools like |
That's a good ideal, but it seems git hook only works on local, do you know is there anyway to run it in github server? |
Seems github didn't support git hooks, the only we can use is web hooks |
Web hook can only do post-check, there is no need to add it since we have unit test to do it (and what I mean is that you should make pkger and push again to pass the unit test) |
a5859aa
to
2e7572d
Compare
Codecov Report
@@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 53.15% 45.11% -8.05%
==========================================
Files 260 260
Lines 18909 18909
==========================================
- Hits 10051 8530 -1521
- Misses 7319 9048 +1729
+ Partials 1539 1331 -208
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
What problem does this PR solve?
implement #877
What is changed and how it works?
Check List
Tests
Code changes
Side effects
Related changes
Release notes: