Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify TiFlash's query memory limit from 10GB to 0(unlimited). #907

Merged
merged 3 commits into from
Nov 17, 2020

Conversation

LittleFall
Copy link
Contributor

What problem does this PR solve?

Modify TiFlash's query memory limit from 10GB to 0(unlimited).

Check List

Tests

  • Integration test

Related changes

  • Need to cherry-pick to the release branch 4.0

Release notes:

Modify TiFlash's query memory limit from 10GB to 0(unlimited).

@CLAassistant
Copy link

CLAassistant commented Nov 16, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Nov 16, 2020

Codecov Report

Merging #907 (7ccb824) into master (402079d) will decrease coverage by 3.94%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #907      +/-   ##
==========================================
- Coverage   53.28%   49.33%   -3.95%     
==========================================
  Files         259      259              
  Lines       18786    18786              
==========================================
- Hits        10010     9269     -741     
- Misses       7244     8073     +829     
+ Partials     1532     1444      -88     
Flag Coverage Δ
cluster 39.96% <100.00%> (-5.59%) ⬇️
dm 25.30% <0.00%> (+0.08%) ⬆️
integrate 44.05% <100.00%> (-3.99%) ⬇️
playground 22.26% <ø> (ø)
tiup 10.75% <0.00%> (ø)
unittest 21.39% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/instance/tiflash_config.go 0.00% <ø> (ø)
pkg/cluster/spec/tiflash.go 66.94% <100.00%> (ø)
components/cluster/command/check.go 6.37% <0.00%> (-72.82%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-51.95%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/operation/operation.go 34.78% <0.00%> (-43.48%) ⬇️
components/cluster/command/rename.go 25.00% <0.00%> (-41.67%) ⬇️
... and 26 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 402079d...7ccb824. Read the comment docs.

@LittleFall
Copy link
Contributor Author

/cc @birdstorm

@LittleFall
Copy link
Contributor Author

/run-integrate-dm-test

@LittleFall
Copy link
Contributor Author

/test

@LittleFall
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 16, 2020
@birdstorm
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@birdstorm birdstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot removed the status/LGT1 Indicates that a PR has LGTM 1. label Nov 17, 2020
@ti-srebot ti-srebot added the status/LGT2 Indicates that a PR has LGTM 2. label Nov 17, 2020
@lucklove lucklove merged commit eacd119 into pingcap:master Nov 17, 2020
@LittleFall LittleFall deleted the patch-1 branch November 17, 2020 05:13
@lucklove lucklove added this to the v1.3.0 milestone Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants