Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

playground: allow a pure TiKV cluster #926

Merged
merged 2 commits into from
Nov 23, 2020

Conversation

sticnarf
Copy link
Contributor

What problem does this PR solve?

I usually need a TiKV environment that is not polluted by TiDB. But the TiDB number check in playground prevents me from it!

What is changed and how it works?

Do not check TiDB number in playground.

Check List

Tests

  • Manual test (add detailed scripts or steps below)

tiup playground --db 0 works \o/

Release notes:

Allow creating a pure TiKV cluster in TiUP playground.

Signed-off-by: Yilin Chen <sticnarf@gmail.com>
@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #926 (076cb5b) into master (fa1a80b) will decrease coverage by 3.83%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #926      +/-   ##
==========================================
- Coverage   55.22%   51.39%   -3.84%     
==========================================
  Files         261      261              
  Lines       19254    19253       -1     
==========================================
- Hits        10633     9895     -738     
- Misses       6918     7744     +826     
+ Partials     1703     1614      -89     
Flag Coverage Δ
cluster 38.26% <ø> (-5.27%) ⬇️
dm 24.10% <ø> (-0.02%) ⬇️
integrate 46.22% <0.00%> (-3.85%) ⬇️
playground 20.23% <0.00%> (+<0.01%) ⬆️
tiup 17.14% <ø> (ø)
unittest 21.64% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 41.16% <0.00%> (+0.07%) ⬆️
components/cluster/command/check.go 6.37% <0.00%> (-72.82%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
pkg/cluster/operation/check.go 0.00% <0.00%> (-51.95%) ⬇️
pkg/cluster/task/rmdir.go 0.00% <0.00%> (-50.00%) ⬇️
pkg/cluster/operation/operation.go 34.78% <0.00%> (-43.48%) ⬇️
components/cluster/command/rename.go 25.00% <0.00%> (-41.67%) ⬇️
components/cluster/command/stop.go 38.46% <0.00%> (-30.77%) ⬇️
... and 23 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa1a80b...076cb5b. Read the comment docs.

@sticnarf
Copy link
Contributor Author

PTAL @lucklove

@AstroProfundis AstroProfundis added good-first-issue type/enhancement Categorizes issue or PR as related to an enhancement. labels Nov 23, 2020
Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 23, 2020
@AstroProfundis
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor

Your auto merge job has been accepted, waiting for:

  • 860
  • 916
  • 922

@ti-srebot ti-srebot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 23, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit abfd109 into pingcap:master Nov 23, 2020
@sticnarf sticnarf deleted the allow-zero-tidb branch December 8, 2020 03:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants