Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the exit order of the components of playground #933

Merged
merged 6 commits into from
Dec 1, 2020

Conversation

unbyte
Copy link
Contributor

@unbyte unbyte commented Nov 24, 2020

What problem does this PR solve?

#859

What is changed and how it works?

run components in new process groups so avoid an unexpected exit order

Check List

Tests

  • Manual test (add detailed scripts or steps below)

Release notes:

playground: consistent exit order of component processes

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2020

CLA assistant check
All committers have signed the CLA.

@codecov-io
Copy link

codecov-io commented Nov 24, 2020

Codecov Report

Merging #933 (5cde1c9) into master (7d602d5) will decrease coverage by 7.92%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #933      +/-   ##
==========================================
- Coverage   55.87%   47.95%   -7.93%     
==========================================
  Files         263      251      -12     
  Lines       19508    19098     -410     
==========================================
- Hits        10901     9158    -1743     
- Misses       6880     8456    +1576     
+ Partials     1727     1484     -243     
Flag Coverage Δ
cluster 34.99% <ø> (-8.40%) ⬇️
dm 24.28% <ø> (-0.02%) ⬇️
integrate 44.26% <ø> (-5.83%) ⬇️
playground ?
tiup 16.80% <ø> (-0.03%) ⬇️
unittest 23.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/playground/playground.go 0.00% <0.00%> (-41.17%) ⬇️
components/playground/monitor.go 0.00% <0.00%> (-84.42%) ⬇️
components/playground/command.go 0.00% <0.00%> (-79.60%) ⬇️
components/cluster/command/check.go 6.37% <0.00%> (-72.82%) ⬇️
pkg/cluster/task/limits.go 0.00% <0.00%> (-68.75%) ⬇️
components/playground/grafana.go 10.16% <0.00%> (-66.95%) ⬇️
pkg/cluster/task/sysctl.go 0.00% <0.00%> (-66.67%) ⬇️
components/playground/main.go 4.00% <0.00%> (-65.50%) ⬇️
components/playground/env.go 0.00% <0.00%> (-57.90%) ⬇️
components/cluster/command/audit.go 27.27% <0.00%> (-54.55%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d602d5...5cde1c9. Read the comment docs.

@unbyte
Copy link
Contributor Author

unbyte commented Nov 24, 2020

image

@AstroProfundis AstroProfundis added good-first-issue type/enhancement Categorizes issue or PR as related to an enhancement. labels Nov 25, 2020
Copy link
Contributor

@AstroProfundis AstroProfundis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@lucklove
Copy link
Member

@you06 PTAL

Copy link

@you06 you06 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@you06, Thanks for your review. The bot only counts LGTMs from Reviewers and higher roles, but you're still welcome to leave your comments. See the corresponding SIG page for more information. Related SIG: tiup(slack).

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Nov 30, 2020
@lucklove
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 30, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: 3fcbb52

@lucklove lucklove added this to the v1.2.6 milestone Nov 30, 2020
@ti-chi-bot
Copy link
Member

@unbyte: Your PR has out-of-dated and I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository.

@ti-chi-bot ti-chi-bot merged commit 214441a into pingcap:master Dec 1, 2020
@lucklove lucklove modified the milestones: v1.2.6, v1.3.0 Dec 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
first-time-contributor size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants