-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the exit order of the components of playground #933
Conversation
Codecov Report
@@ Coverage Diff @@
## master #933 +/- ##
==========================================
- Coverage 55.87% 47.95% -7.93%
==========================================
Files 263 251 -12
Lines 19508 19098 -410
==========================================
- Hits 10901 9158 -1743
- Misses 6880 8456 +1576
+ Partials 1727 1484 -243
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@you06 PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/lgtm |
/merge |
Can merge label has been added. Git tree hash: 3fcbb52
|
@unbyte: Your PR has out-of-dated and I have automatically updated it for you. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the tidb-community-bots/ti-community-prow repository. |
What problem does this PR solve?
#859
What is changed and how it works?
run components in new process groups so avoid an unexpected exit order
Check List
Tests
Release notes: