Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/make goimports typo error #934

Merged
merged 4 commits into from
Nov 25, 2020

Conversation

9547
Copy link
Contributor

@9547 9547 commented Nov 24, 2020

What problem does this PR solve?

What is changed and how it works?

  • gimports -> goimports;
  • use golangci-lint to fix some spelling and style format;
  • I'll trigger another PR to fix the other linting problems;

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 25, 2020
@AstroProfundis AstroProfundis added cherrypick/1.2 type/enhancement Categorizes issue or PR as related to an enhancement. labels Nov 25, 2020
@AstroProfundis AstroProfundis merged commit c989f9d into pingcap:master Nov 25, 2020
@9547 9547 deleted the fix/make-goimports-typo-error branch April 6, 2021 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1. type/enhancement Categorizes issue or PR as related to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants