Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug for only one directory in TiFlash storage.* configuration #938

Merged
merged 1 commit into from
Nov 26, 2020

Conversation

JaySon-Huang
Copy link
Contributor

@JaySon-Huang JaySon-Huang commented Nov 25, 2020

Signed-off-by: JaySon-Huang tshent@qq.com

What problem does this PR solve?

If there is only one directory in TiFlash storage.* configuration, the TiFlashSpec DataDir become unexpected value.
Introduced by #931

What is changed and how it works?

Fix a bug that if there is only one directory in TiFlash storage.* configuration

Check List

Tests

  • Unit test

Code changes

  • N/A

Side effects

  • N/A

Related changes

  • Need to cherry-pick to the release branch

Release notes:

NONE

Signed-off-by: JaySon-Huang <tshent@qq.com>
@codecov-io
Copy link

codecov-io commented Nov 25, 2020

Codecov Report

Merging #938 (3f19678) into master (1f0cbac) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #938      +/-   ##
==========================================
- Coverage   55.70%   55.66%   -0.04%     
==========================================
  Files         263      263              
  Lines       19389    19392       +3     
==========================================
- Hits        10800    10795       -5     
- Misses       6875     6880       +5     
- Partials     1714     1717       +3     
Flag Coverage Δ
cluster 43.36% <0.00%> (-0.08%) ⬇️
dm 23.99% <0.00%> (+0.05%) ⬆️
integrate 49.90% <0.00%> (-0.05%) ⬇️
playground 20.21% <ø> (ø)
tiup 16.92% <0.00%> (-0.01%) ⬇️
unittest 23.04% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
pkg/cluster/spec/tiflash.go 72.25% <100.00%> (+0.24%) ⬆️
pkg/cluster/spec/util.go 76.74% <0.00%> (-4.66%) ⬇️
pkg/cluster/api/pdapi.go 58.82% <0.00%> (-1.86%) ⬇️
pkg/cluster/manager.go 67.75% <0.00%> (-0.15%) ⬇️
pkg/cluster/api/dmapi.go 60.00% <0.00%> (+1.73%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f0cbac...3f19678. Read the comment docs.

Copy link
Member

@lucklove lucklove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 26, 2020
@lucklove lucklove merged commit 7c52950 into pingcap:master Nov 26, 2020
@JaySon-Huang JaySon-Huang deleted the tiflash_storage_section branch November 26, 2020 06:45
AstroProfundis pushed a commit that referenced this pull request Nov 27, 2020
@lucklove lucklove added this to the v1.2.5 milestone Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants