Support host names in TLS certificates #948
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #948 +/- ##
==========================================
- Coverage 55.86% 52.07% -3.80%
==========================================
Files 263 263
Lines 19509 19513 +4
==========================================
- Hits 10899 10161 -738
- Misses 6882 7711 +829
+ Partials 1728 1641 -87
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
AstroProfundis
approved these changes
Nov 30, 2020
|
/lgtm |
ti-chi-bot
added
status/LGT1
fln
force-pushed
the
support_hosts_in_tls_certs
branch
from
c36984d
to
998b012
Compare
This commit updates TLS certificate generator to detect if IP address or host name was used as host value. If host name is detected field `DNSNames` of x509 SAN extenstion is used instead of `IPAddresses`. * https://en.wikipedia.org/wiki/Subject_Alternative_Name * https://tools.ietf.org/html/rfc5280#section-4.2.1.6 This contributes towards fixing pingcap#337.
fln
force-pushed
the
support_hosts_in_tls_certs
branch
from
998b012
to
2006b2e
Compare
|
/merge |
ti-chi-bot
added
the
status/can-merge
|
Can merge label has been added. Git tree hash: acc0b47
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
This PR updates TLS certificate generator to support issuing certificates for host names, not only IP addresses.
This contributes towards fixing #337.
What is changed and how it works?
If host name is detected field
DNSNamesof x509 SAN extenstion is used instead ofIPAddresses.Check List
Tests
Integration tests that cover this functionality is available in #950.
Release notes: