-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Playground: support setting custom timeout for waiting instances up #968
Conversation
Codecov Report
@@ Coverage Diff @@
## master #968 +/- ##
==========================================
- Coverage 55.79% 51.54% -4.25%
==========================================
Files 263 263
Lines 19541 19768 +227
==========================================
- Hits 10903 10190 -713
- Misses 6907 7937 +1030
+ Partials 1731 1641 -90
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/lgtm |
/lgtm cancel |
solved |
/lgtm |
/merge |
Can merge label has been added. Git tree hash: bb5dc14
|
What problem does this PR solve?
#962
Currently tiup playground will wait for tidb up in 60 seconds, and if it fails, tiflash instance will be ignored. However, sometimes tidb instances start normally but only the startup time exceeds the timeout time. So maybe support setting custom timeout for waiting instances up can help.
What is changed and how it works?
remove waiting for tikv
check tidb and tiflash status in parallel
Check List
Tests
Related changes
Release notes:
close #962