Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split cluster into small files #979

Merged

Conversation

9547
Copy link
Contributor

@9547 9547 commented Dec 9, 2020

What problem does this PR solve?

ref #958 (comment)

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change

Side effects

  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release notes:

NONE

@ti-chi-bot ti-chi-bot requested a review from nrc December 9, 2020 19:14
@ti-chi-bot ti-chi-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 9, 2020
@codecov-io
Copy link

codecov-io commented Dec 9, 2020

Codecov Report

Merging #979 (ae368b4) into master (9e5f2bd) will decrease coverage by 0.15%.
The diff coverage is 68.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
- Coverage   55.55%   55.40%   -0.16%     
==========================================
  Files         264      279      +15     
  Lines       19858    19709     -149     
==========================================
- Hits        11032    10919     -113     
+ Misses       7101     7071      -30     
+ Partials     1725     1719       -6     
Flag Coverage Δ
cluster 43.23% <66.62%> (-0.23%) ⬇️
dm 23.81% <44.66%> (-0.23%) ⬇️
integrate 49.66% <67.57%> (-0.20%) ⬇️
playground 20.29% <0.00%> (ø)
tiup 16.45% <0.00%> (ø)
unittest 23.08% <1.43%> (+0.21%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
components/dm/command/import.go 19.35% <0.00%> (+0.30%) ⬆️
components/dm/command/patch.go 50.00% <0.00%> (ø)
pkg/repository/mirror.go 39.35% <0.00%> (ø)
pkg/cluster/manager/rename.go 25.00% <25.00%> (ø)
pkg/cluster/manager/edit_config.go 31.25% <31.25%> (ø)
pkg/cluster/manager/cleanup.go 33.33% <33.33%> (ø)
pkg/cluster/manager/scale_out.go 50.76% <50.76%> (ø)
pkg/cluster/manager/patch.go 51.80% <51.80%> (ø)
pkg/cluster/manager/cacert.go 53.19% <53.19%> (ø)
pkg/cluster/manager/scale_in.go 59.52% <59.52%> (ø)
... and 67 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e5f2bd...ae368b4. Read the comment docs.

@lucklove
Copy link
Member

/lgtm

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Dec 11, 2020
@lucklove
Copy link
Member

/merge

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 11, 2020
@ti-chi-bot
Copy link
Member

Can merge label has been added.

Git tree hash: ae368b4

@ti-chi-bot ti-chi-bot merged commit 91466ae into pingcap:master Dec 11, 2020
@9547 9547 deleted the feature/split-cluster-into-small-files branch April 6, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants