Update to jakarta #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kqarryzada
requested changes
Aug 14, 2024
There was a problem hiding this comment.
This looks good overall. I have a few additional suggestions:
We should guarantee that the project is un-compilable by old JDK versions. I suggest making the following change to com.unboundid.scim.sdk.ComplexSCIMAttributeValue#equals since it will also clean things up a bit:
// Current:
com.unboundid.scim.sdk.ComplexSCIMAttributeValue that =
(com.unboundid.scim.sdk.ComplexSCIMAttributeValue) o;
// Suggested replacement:
var that = (ComplexSCIMAttributeValue) o;Can you also squash the commits in the branch manually and provide a detailed commit message? Something like the following is a good start, but you can write whatever you see fit:
Support Jakarta EE namespaces in the SCIM 1.1 SDK
Updated usages of Java EE components to utilize Jakarta EE instead. This
requires updating the compile version of the project to JDK 11, so the
release version has been updated to 2.0.0-SNAPSHOT.
JiraIssue: (issue)
scim-sdk/src/main/java/com/unboundid/scim/marshal/xml/XmlStreamMarshaller.java
Show resolved
Hide resolved
Support Jakarta EE namespaces in the SCIM 1.1 SDK Updated usages of Java EE components to utilize Jakarta EE instead. This requires updating the compile version of the project to JDK 11, so the release version has been updated to 2.0.0-SNAPSHOT. JiraIssue: DS-48037
justin-schwausch
force-pushed
the
update-to-jakarta
branch
from
0268bdd
to
5ddad06
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of PDs migration from Javax to Jakarta, the SCIM SDK also needs to be migrated.