Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix customLogLevel usage in onResFinished function #272

Merged
merged 2 commits into from
Feb 5, 2023
Merged

Fix customLogLevel usage in onResFinished function #272

merged 2 commits into from
Feb 5, 2023

Conversation

kanmir
Copy link
Contributor

@kanmir kanmir commented Jan 31, 2023

Hi!

I found a bug.
There is a missing req argument in getLogLevelFromCustomLogLevel function call at onResFinished

Because of this, I got an error TypeError: Cannot read properties of undefined (reading 'req'), when using customLogLevel option

mcollina
mcollina requested changes Feb 1, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening a PR! Can you please add a unit test?

@kanmir kanmir requested a review from mcollina February 4, 2023 21:12
mcollina
mcollina approved these changes Feb 5, 2023
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 9d17cfb into pinojs:master Feb 5, 2023
@kanmir kanmir deleted the kanmir/fix-customLogLevel branch February 6, 2023 07:47
@sawood14012 sawood14012 mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kanmir @mcollina