Fix #42

logger.js

@@ -12,7 +12,7 @@ function pinoLogger (opts, stream) {
 
   opts = opts || {}
   opts.serializers = opts.serializers || {}
-  opts.serializers.req = opts.serializers.req || asReqValue
+  opts.serializers.req = wrapReqSerializer(opts.serializers.req || asReqValue)
   opts.serializers.res = opts.serializers.res || pino.stdSerializers.res
   opts.serializers.err = opts.serializers.err || pino.stdSerializers.err
 
@@ -64,16 +64,71 @@ function pinoLogger (opts, stream) {
   }
 }
 
+var rawSymbol = Symbol.for('pino-raw-request')
+var pinoReqProto = Object.create({}, {
+  id: {
+    enumerable: true,
+    writable: true,
+    value: ''
+  },
+  method: {
+    enumerable: true,
+    writable: true,
+    value: ''
+  },
+  url: {
+    enumerable: true,
+    writable: true,
+    value: ''
+  },
+  headers: {
+    enumerable: true,
+    writable: true,
+    value: {}
+  },
+  remoteAddress: {
+    enumerable: true,
+    writable: true,
+    value: ''
+  },
+  remotePort: {
+    enumerable: true,
+    writable: true,
+    value: ''
+  },
+  raw: {
+    enumerable: false,
+    get: function () {
+      return this[rawSymbol]
+    },
+    set: function (val) {
+      this[rawSymbol] = val
+    }
+  }
+})
+Object.defineProperty(pinoReqProto, rawSymbol, {
+  writable: true,
+  value: {}
+})
+
+function wrapReqSerializer (serializer) {
+  if (serializer === asReqValue) return asReqValue
+  return function wrappedReqSerializer (req) {
+    return serializer(asReqValue(req))
+  }
+}
+
 function asReqValue (req) {
   var connection = req.connection
-  return {
-    id: req.id,
-    method: req.method,
-    url: req.url,
-    headers: req.headers,
-    remoteAddress: connection && connection.remoteAddress,
-    remotePort: connection && connection.remotePort
-  }
+  const _req = Object.create(pinoReqProto)
+  _req.id = req.id
+  _req.method = req.method
+  _req.url = req.url
+  _req.headers = req.headers
+  _req.remoteAddress = connection && connection.remoteAddress
+  _req.remotePort = connection && connection.remotePort
+  _req.raw = req
+  return _req
 }
 
 function wrapChild (opts, stream) {

test.js

@@ -303,3 +303,34 @@ test('does not crash when no request connection object', function (t) {
     res.end()
   }
 })
+
+// https://github.com/pinojs/pino-http/issues/42
+test('does not return excessively long object', function (t) {
+  var dest = split(JSON.parse)
+  var logger = pinoHttp({
+    logger: pino(dest),
+    serializers: {
+      req: function (req) {
+        delete req.connection
+        return req
+      }
+    }
+  })
+  t.plan(1)
+
+  var server = http.createServer(handler)
+  server.unref()
+  server.listen(0, () => {
+    const port = server.address().port
+    http.get(`http://127.0.0.1:${port}`, () => {})
+  })
+
+  function handler (req, res) {
+    logger(req, res)
+    res.end()
+  }
+
+  dest.on('data', function (obj) {
+    t.is(Object.keys(obj.req).length, 6)
+  })
+})