Fix setting request id #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
mcollina
reviewed
Dec 9, 2017
logger.js
Outdated
| @@ -121,7 +121,7 @@ function wrapReqSerializer (serializer) { | |||
| function asReqValue (req) { | |||
| var connection = req.connection | |||
| const _req = Object.create(pinoReqProto) | |||
| _req.id = req.id | |||
| _req.id = Function.prototype.isPrototypeOf(req.id) ? req.id() : req.id | |||
There was a problem hiding this comment.
why not typeof req.id === 'function'? Which one is faster?
There was a problem hiding this comment.
unless there's a speed benefit.. definitely go with typeof here...
There was a problem hiding this comment.
/shrug, I prefer using the actual API. I haven't tested for any difference in speed.
test.js
Outdated
| logger: pino(dest), | ||
| serializers: { | ||
| req: function (req) { | ||
| t.is(Function.isPrototypeOf(req.id), false) |
There was a problem hiding this comment.
prefer typeof - unless there's some really awesome reasons
test.js
Outdated
| server.unref() | ||
| server.listen(0, () => { | ||
| const port = server.address().port | ||
| http.get(`http://127.0.0.1:${port}`, () => {}) |
There was a problem hiding this comment.
pointless pedantry: you could just do http.get(server.address(), () => {})
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While updating
restify-pino-loggerI learned that the request id property was not getting set properly. I'm don't know how it ever was. Consider:First it's set to a function and then that function is assigned to the property.
This PR simply invokes the
req.idfunction in the serializer if it is actually a function. Otherwise it assigns whatever that value is to the property.