Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customColors to typescript definition for PrettyOptions #440

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

Hufschmidt
Copy link
Contributor

See #439

Also contains minor cleanup of type test-file.


This assumes index.d.ts is managed manually and not autogenerated by some process as I didn't see any related script in package.json.

Also I've not worked with TSD so far, so I only added the missing example values for customLevels and customColors parameters to the options.
A quick inverse check confirmed tests working as expected as they failed without adding customColors to the type definition. 👍

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@coveralls
Copy link

Pull Request Test Coverage Report for Build 5599626822

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 5455898307: 0.0%
Covered Lines: 410
Relevant Lines: 410

💛 - Coveralls

@mcollina mcollina merged commit d195503 into pinojs:master Jul 19, 2023
6 checks passed
renovate bot added a commit to fwouts/previewjs that referenced this pull request Jul 23, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`^10.0.1` ->
`^10.1.0`](https://renovatebot.com/diffs/npm/pino-pretty/10.0.1/10.1.0)
|
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/10.0.1/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/10.0.1/10.1.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v10.1.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.1.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v10.0.1...v10.1.0)

#### What's Changed

- Add customColors to typescript definition for PrettyOptions by
[@&#8203;Hufschmidt](https://togithub.com/Hufschmidt) in
[pinojs/pino-pretty#440

#### New Contributors

- [@&#8203;Hufschmidt](https://togithub.com/Hufschmidt) made their first
contribution in
[pinojs/pino-pretty#440

**Full Changelog**:
pinojs/pino-pretty@v10.0.1...v10.1.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these
updates again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/fwouts/previewjs).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMS4wIiwidXBkYXRlZEluVmVyIjoiMzYuMTEuMCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
bodinsamuel pushed a commit to specfy/specfy that referenced this pull request Aug 7, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [pino-pretty](https://togithub.com/pinojs/pino-pretty) | [`10.0.0` ->
`10.2.0`](https://renovatebot.com/diffs/npm/pino-pretty/10.0.0/10.2.0) |
[![age](https://developer.mend.io/api/mc/badges/age/npm/pino-pretty/10.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/npm/pino-pretty/10.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/npm/pino-pretty/10.0.0/10.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/npm/pino-pretty/10.0.0/10.2.0?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>pinojs/pino-pretty (pino-pretty)</summary>

###
[`v10.2.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.2.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v10.1.0...v10.2.0)

#### What's Changed

- Remove coveralls by [@&#8203;jsumners](https://togithub.com/jsumners)
in
[pinojs/pino-pretty#443
- Add support for messageFormat strings containing conditionals by
[@&#8203;timlohse1104](https://togithub.com/timlohse1104) in
[pinojs/pino-pretty#442

#### New Contributors

- [@&#8203;timlohse1104](https://togithub.com/timlohse1104) made their
first contribution in
[pinojs/pino-pretty#442

**Full Changelog**:
pinojs/pino-pretty@v10.1.0...v10.2.0

###
[`v10.1.0`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.1.0)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v10.0.1...v10.1.0)

#### What's Changed

- Add customColors to typescript definition for PrettyOptions by
[@&#8203;Hufschmidt](https://togithub.com/Hufschmidt) in
[pinojs/pino-pretty#440

#### New Contributors

- [@&#8203;Hufschmidt](https://togithub.com/Hufschmidt) made their first
contribution in
[pinojs/pino-pretty#440

**Full Changelog**:
pinojs/pino-pretty@v10.0.1...v10.1.0

###
[`v10.0.1`](https://togithub.com/pinojs/pino-pretty/releases/tag/v10.0.1)

[Compare
Source](https://togithub.com/pinojs/pino-pretty/compare/v10.0.0...v10.0.1)

**Full Changelog**:
pinojs/pino-pretty@v9.4.1...v10.0.1

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "after 4pm on friday,before 9am on
monday,every weekend" in timezone Europe/Paris, Automerge - At any time
(no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/specfy/specfy).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4yNy4xIiwidXBkYXRlZEluVmVyIjoiMzYuMjcuMSIsInRhcmdldEJyYW5jaCI6ImNob3JlL3Jlbm92YXRlQmFzZUJyYW5jaCJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants