Nested VError causes #108
Merged
Nested VError causes #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Extracts evaluateCause from inside err-helpers and reuses it in error serialization to support nested causes where .cause is a function.
voxpelli
added a commit
to voxpelli/pino-std-serializers
that referenced
this pull request
Jun 13, 2022
This reverts commit 5b88f7e.
voxpelli
added a commit
to voxpelli/pino-std-serializers
that referenced
this pull request
Jun 13, 2022
Instead rely on its content being appended to the message and the stack. This is an alternative fix to pinojs#94, replacing pinojs#105 and pinojs#108 + makes pinojs#109 not needed
mcollina
pushed a commit
that referenced
this pull request
Jun 13, 2022
…ead (#110) * Revert "Nested VError causes (#108)" This reverts commit 5b88f7e. * Revert "Serialize errors with cause (#105)" This reverts commit ae83956. * Never serialize `.cause` when an `Error` Instead rely on its content being appended to the message and the stack. This is an alternative fix to #94, replacing #105 and #108 + makes #109 not needed * Add tests * Add explainer comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was bugging me that I had left out support for VError-style errors that are supported elsewhere when I made #105, so here's a PR adding support for that 😄