-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update target versions (CI) #21
Conversation
test/transport.test.js
Outdated
@@ -35,6 +35,9 @@ test('syslog pino transport test rfc3164', async t => { | |||
level: 'info', | |||
options: sysLogOptions | |||
}) | |||
t.teardown(() => { | |||
transport.end() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mcollina and @Eomm on Node >= 18 this line generates an error because this while loop is being iterated too many times https://github.com/pinojs/thread-stream/blob/e8ce6b22a4d8d311aa3fc47357dbcefcc67bc8c5/index.js#L418-L432
I'm not clear what the issue is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
I'll take a look asap |
Needs pinojs/thread-stream#109 |
Finally it all passed. Sigh. |
🤣 thanks for working on it. I'll merge and release this next time I have availability. It needs to be a semver major because of at least #9. |
No description provided.