Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Solve bug leading zero on date format #7

Merged
merged 2 commits into from
Feb 18, 2019
Merged

Solve bug leading zero on date format #7

merged 2 commits into from
Feb 18, 2019

Conversation

loic-b
Copy link
Contributor

@loic-b loic-b commented Feb 18, 2019

Previously, the RFC3164 formatters removed any zero in the date.
The right thing to do is to remove only the first leading zero.

jsumners
jsumners approved these changes Feb 18, 2019
View reviewed changes
Copy link
Member

@jsumners jsumners left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsumners jsumners merged commit 7a416c8 into pinojs:master Feb 18, 2019
@jsumners
Copy link
Member

https://github.com/pinojs/pino-syslog/releases/tag/v1.2.1

@jsumners jsumners mentioned this pull request Feb 18, 2019
Closed
@loic-b loic-b deleted the issue-RFC3164-dateformat branch February 19, 2019 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsumners jsumners jsumners approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@loic-b @jsumners