add new streamWrite hook #2105
Merged
add new streamWrite hook #2105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mcollina I don't have a dedicated system I can run the benchmarks on. Can you run them? The CI results are too variable to be of much use. |
mcollina
approved these changes
Dec 12, 2024
jsumners
approved these changes
Dec 12, 2024
|
appears to be an unrelated intermittent test failure? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
streamWritehook which is able to modify the final stringified log just before it written to a transport (stream).The use case here is to allow a user (or plugin author like myself) to scrub known sensitive secrets from logs before they are sent out to various transports, regardless of how these values ended up there (see #2102)
I played around with injecting a hook in a few different places but this seemed like the simplest and best place for it to go. Obviously could add more checks / tests / etc, but overall seems fairly simple.
Please let me know if you have any concerns or anything else you would like to see.