Add pino-browser support for hapi-pino #612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes browser.js to expose symbols and serializer methods used by hapi-pino. This is extremely niche use case, but some people want to run Hapi.js (HTTP server) in WebExtension context using chrome.sockets APIs. Ref. ipfs/ipfs-companion#664 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
|
Can you add unit test? |
4 tasks
License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
|
@mcollina Added, coverage is 100% again. |
mcollina
pushed a commit
to hapijs/hapi-pino
that referenced
this pull request
Apr 27, 2019
Switch to pino v5.12.3 which includes fix from pinojs/pino#612 License: MIT Signed-off-by: Marcin Rataj <lidel@lidel.org>
This was referenced May 11, 2019
Merged
Merged
davidmarkclements
added a commit
to hapijs/hapi-pino
that referenced
this pull request
May 14, 2019
niche browser support case (cf pinojs/pino#612)
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
browser.jsto expose/stub symbols and serializer methods expected byhapi-pino.Without this, TypeError happens here and here.
This is useful in extremely niche use case when one wants to run code with embedded Hapi (HTTP server) in browser context enriched with chrome.sockets APIs (such as Chrome Apps or blessed extensions in Chromium-based browsers).
In my case, to run js-ipfs (with embedded hapi) in WebExtension context: ipfs/ipfs-companion#664 / ipfs/ipfs-companion#716