[#10693] enable grpc built-in retry by default

pinpoint-apm · Aug 12, 2024 · 88112ea · 88112ea
1 parent 3215895
commit 88112ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/agent-module/agent/src/main/resources/pinpoint-root.config b/agent-module/agent/src/main/resources/pinpoint-root.config
@@ -53,7 +53,9 @@ profiler.transport.grpc.metadata.ssl.enable=false
 profiler.transport.grpc.metadata.sender.executor.queue.size=1000
 profiler.transport.grpc.metadata.sender.channel.executor.queue.size=1000
 profiler.transport.grpc.metadata.sender.request.timeout.millis=6000
+# This configuration is used only if profiler.transport.grpc.metadata.sender.retry.enable=false
 profiler.transport.grpc.metadata.sender.retry.max.count=3
+# This configuration is used only if profiler.transport.grpc.metadata.sender.retry.enable=false
 profiler.transport.grpc.metadata.sender.retry.delay.millis=1000
 profiler.transport.grpc.metadata.sender.keepalive.time.millis=30000
 profiler.transport.grpc.metadata.sender.keepalive.timeout.millis=60000
@@ -134,7 +136,7 @@ profiler.system.property.io.netty.noPreferDirect=false
 
 # Enable Grpc Hedging Policy
 # https://github.com/grpc/proposal/blob/master/A6-client-retries.md#hedging-policy
-profiler.transport.grpc.metadata.sender.retry.enable=false
+profiler.transport.grpc.metadata.sender.retry.enable=true
 profiler.transport.grpc.metadata.sender.max.attempts=3
 profiler.transport.grpc.metadata.sender.hedging.delay.millis=1000
 # 16777216 = 64m

diff --git a/grpc/src/main/java/com/navercorp/pinpoint/grpc/Header.java b/grpc/src/main/java/com/navercorp/pinpoint/grpc/Header.java
@@ -143,7 +143,7 @@ public String toString() {
                 ", socketId=" + socketId +
                 ", serviceType=" + serviceType +
                 ", supportCommandCodeList=" + supportCommandCodeList +
-                ", retryFriendlyResponse='" + grpcBuiltInRetry + '\'' +
+                ", grpcBuiltInRetry='" + grpcBuiltInRetry + '\'' +
                 ", properties=" + properties +
                 '}';
     }