Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add profiler.uri.stat.collect.http.method option to collect uri statistics with http methods #10220

Closed
ga-ram opened this issue Aug 16, 2023 · 0 comments
Assignees
Milestone

Comments

@ga-ram
Copy link
Contributor

ga-ram commented Aug 16, 2023

Current URI statistics only collects URI.
When an application uses RESTful APIs, a single URI can have multiple behaviours (e.g., GET /user and DELETE /user) so it is worth collecting URI with http methods.

When profiler.uri.stat.collect.http.method = false (default value), Pinpoint agent will behave the same as before.
When profiler.uri.stat.collect.http.method = true, Pinpoint agent will collect URI statistics with a key httpMethod URI(GET /user, DELETE /user) instead of just URI (/user).

Screenshot 2023-08-16 at 4 53 44 PM

@ga-ram ga-ram added this to the 2.6.0 milestone Aug 16, 2023
@ga-ram ga-ram self-assigned this Aug 16, 2023
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Aug 16, 2023
…on to collect uri statistics with http methods
ga-ram added a commit to ga-ram/pinpoint that referenced this issue Aug 16, 2023
…on to collect uri statistics with http methods
ga-ram added a commit that referenced this issue Aug 21, 2023
@ga-ram ga-ram closed this as completed Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant