Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change behavior of agent disable option #10643

Closed
donghun-cho opened this issue Jan 24, 2024 · 0 comments · Fixed by #10645
Closed

change behavior of agent disable option #10643

donghun-cho opened this issue Jan 24, 2024 · 0 comments · Fixed by #10645
Assignees
@donghun-cho
Labels
configuration module:agent
Milestone
3.0.0

Comments

@donghun-cho
Copy link
Contributor

Add a check on value of disable option as well as the existence of the option
If the disable option is configured in the Pinpoint agent configuration file, agent will be stopped during the loading process

  • If the disable option's value is not false, disable pinpoint agent
  • the disable option can be configured in configuration file
    • Although it works slightly differently
  • configuration file changes
    • Remove profile.enable=true option, as it does not work.
    • Add pinpoint.disable=false option
@donghun-cho donghun-cho added this to the 3.0.0 milestone Jan 24, 2024
@donghun-cho donghun-cho self-assigned this Jan 24, 2024
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jan 24, 2024
@donghun-cho
[pinpoint-apm#10643] Change behavior of disable option
159af75
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jan 24, 2024
@donghun-cho
[pinpoint-apm#10643] Change behavior of disable option
11f1b5c
@donghun-cho donghun-cho mentioned this issue Jan 24, 2024
Merged
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Jan 24, 2024
@donghun-cho
[pinpoint-apm#10643] Change behavior of disable option
db9ccb8
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Feb 8, 2024
@donghun-cho
[pinpoint-apm#10643] Change behavior of disavle option
e23c42e
donghun-cho added a commit to donghun-cho/pinpoint that referenced this issue Feb 13, 2024
@donghun-cho
[pinpoint-apm#10643] Change behavior of disable option
0fb33e0
donghun-cho added a commit that referenced this issue Feb 13, 2024
@donghun-cho
[#10643] Change behavior of disable option
81ab285
@donghun-cho donghun-cho linked a pull request Feb 14, 2024 that will close this issue
[#10643] Change behavior of disable option #10645
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@donghun-cho donghun-cho

Labels
configuration module:agent
Projects
None yet
Milestone
3.0.0
Development

Successfully merging a pull request may close this issue.

[#10643] Change behavior of disable option donghun-cho/pinpoint
1 participant
@donghun-cho