Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pinpoint SDK for asynchronous operation #7654

Closed
emeroad opened this issue Feb 9, 2021 · 2 comments · Fixed by #7750
Closed

Pinpoint SDK for asynchronous operation #7654

emeroad opened this issue Feb 9, 2021 · 2 comments · Fixed by #7750
Labels
enhancement module:agent module:plugin
Milestone
2.3.0

Comments

@emeroad
Copy link
Member

emeroad commented Feb 9, 2021 •
edited by koo-taejin
Loading

contribution info

description

This approach is simple and very effective.

​​#7649 design

  1. SDK provides Runnable and Executor classes
  • Now the target class to instrument is determined by the SDK
  1. Async plug-in instrument the SDK class.

My design

  1. Agent provides API for async operation.
  2. SDK uses the agent's API to measure performance.

Weakness

  • API should be provided through Boostrap-classloader. Its development is very complicated.
  • Difficulty maintaining compatibility between SDK and agent API.
@emeroad emeroad changed the title Pinpoint Client SDK for asynchronous operation Pinpoint SDK for asynchronous operation Feb 9, 2021
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 19, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
2c30a67
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 19, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
a2c3e6d
@emeroad emeroad mentioned this issue Mar 19, 2021
Open
@emeroad
Copy link
Member Author

emeroad commented Mar 19, 2021

@zhangyinhao1234
Your PR disappeared as I pushed my rebase revision to the master branch.
It's my mistake. I have not found the cause of this problem. I'm really sorry.

I made a new branch and restored it.

emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 19, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
37dc520
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 19, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
bd328d1
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 23, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
2903007
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 23, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
1dbaf31
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 24, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
b47e27a
emeroad added a commit to emeroad/pinpoint that referenced this issue Mar 24, 2021
@emeroad
[pinpoint-apm#7654] Async support SDK
680fff7
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 26, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
0ce2885
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 26, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
b3bdfd2
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 29, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
5e6574d
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Mar 29, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
fb4ae1e
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Apr 5, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
1ca2c97
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Apr 6, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
2725f5b
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Apr 6, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
f416fe0
emeroad pushed a commit to emeroad/pinpoint that referenced this issue Apr 23, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
e7e575f
emeroad pushed a commit to emeroad/pinpoint that referenced this issue May 7, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
da797ec
emeroad added a commit to emeroad/pinpoint that referenced this issue May 7, 2021
@emeroad
[pinpoint-apm#7654] Add base packgeoption
0c1293a
emeroad pushed a commit to emeroad/pinpoint that referenced this issue May 7, 2021
@zhangyinhao1234 @emeroad
[pinpoint-apm#7654] Async support SDK
5170af7
emeroad added a commit to emeroad/pinpoint that referenced this issue May 7, 2021
@emeroad
[pinpoint-apm#7654] Add base package option
912fc96
@emeroad emeroad linked a pull request May 7, 2021 that will close this issue
[#7654] Async support SDK #7750
Merged
emeroad pushed a commit that referenced this issue May 7, 2021
@zhangyinhao1234 @emeroad
[#7654] Async support SDK
56d0a11
emeroad added a commit that referenced this issue May 7, 2021
@emeroad
[#7654] Add base package option
4bb8ea6
@koo-taejin koo-taejin added this to the 2.3.0 milestone Jul 20, 2021
@zhangyinhao1234
Copy link
Contributor

I'm glad my design was adopted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement module:agent module:plugin
Projects
None yet
Milestone
2.3.0
Development

Successfully merging a pull request may close this issue.

[#7654] Async support SDK emeroad/pinpoint
3 participants
@zhangyinhao1234 @emeroad @koo-taejin