Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#9932] Replace with Netty4 #10007

Merged
merged 2 commits into from
May 31, 2023
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented May 30, 2023

No description provided.

@emeroad emeroad added this to the 2.6.0 milestone May 30, 2023
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #10007 (ae498be) into master (8e3ad78) will increase coverage by 0.01%.
The diff coverage is 66.01%.

@@             Coverage Diff              @@
##             master   #10007      +/-   ##
============================================
+ Coverage     38.58%   38.59%   +0.01%     
- Complexity    11613    11626      +13     
============================================
  Files          3571     3573       +2     
  Lines         93275    93340      +65     
  Branches      10310    10320      +10     
============================================
+ Hits          35986    36022      +36     
- Misses        54209    54232      +23     
- Partials       3080     3086       +6     
Impacted Files Coverage Δ
.../navercorp/pinpoint/io/DefaultResponseMessage.java 0.00% <0.00%> (ø)
...ercorp/pinpoint/collector/util/RequestManager.java 51.92% <51.92%> (ø)
.../navercorp/pinpoint/rpc/client/RequestManager.java 63.07% <66.66%> (-1.63%) ⬇️
...orp/pinpoint/rpc/server/DefaultPinpointServer.java 79.59% <75.00%> (-0.25%) ⬇️
...nt/collector/receiver/grpc/PinpointGrpcServer.java 48.58% <88.88%> (+1.18%) ⬆️
...eiver/grpc/service/command/GrpcCommandService.java 52.12% <100.00%> (+0.58%) ⬆️
...p/pinpoint/collector/util/RequestFailListener.java 100.00% <100.00%> (ø)
...point/rpc/client/DefaultPinpointClientHandler.java 72.43% <100.00%> (+0.09%) ⬆️
.../navercorp/pinpoint/rpc/packet/ResponsePacket.java 46.42% <100.00%> (-1.85%) ⬇️

... and 4 files with indirect coverage changes

@emeroad emeroad merged commit 26f8c8b into pinpoint-apm:master May 31, 2023
@emeroad emeroad deleted the #9932_remove_thrift branch June 5, 2023 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant