Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10079] Propagate pubsub req cancellation #10080

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

smilu97
Copy link
Contributor

@smilu97 smilu97 commented Jun 26, 2023

resolves #10079

@smilu97 smilu97 self-assigned this Jun 26, 2023
@codecov
Copy link

codecov bot commented Jun 26, 2023

Codecov Report

Merging #10080 (383ddd4) into master (d9ef155) will decrease coverage by 0.42%.
The diff coverage is 11.81%.

@@             Coverage Diff              @@
##             master   #10080      +/-   ##
============================================
- Coverage     38.86%   38.44%   -0.42%     
+ Complexity    11907    11658     -249     
============================================
  Files          3538     3608      +70     
  Lines         93995    93905      -90     
  Branches      10496    10364     -132     
============================================
- Hits          36528    36099     -429     
- Misses        54296    54719     +423     
+ Partials       3171     3087      -84     
Impacted Files Coverage Δ
.../navercorp/pinpoint/bootstrap/config/Profiles.java 0.00% <ø> (ø)
...ptor/AsyncContextSpanEventEndPointInterceptor.java 0.00% <0.00%> (ø)
...tor/SpanEventSimpleAroundInterceptorForPlugin.java 13.33% <0.00%> (-1.31%) ⬇️
...otstrap/plugin/request/ServletRequestListener.java 0.00% <0.00%> (ø)
...strap/plugin/response/ServletResponseListener.java 0.00% <0.00%> (ø)
...npoint/bootstrap/config/ProfilePropertyLoader.java 20.00% <0.00%> (-0.32%) ⬇️
...oint/bootstrap/config/SimpleLogConfigResolver.java 0.00% <0.00%> (ø)
...inpoint/bootstrap/config/SimplePropertyLoader.java 0.00% <0.00%> (ø)
...rp/pinpoint/collector/PinpointCollectorModule.java 0.00% <ø> (ø)
...inpoint/collector/cluster/GrpcAgentConnection.java 28.12% <0.00%> (-50.00%) ⬇️
... and 136 more

... and 377 files with indirect coverage changes

@smilu97 smilu97 merged commit 6c39624 into pinpoint-apm:master Jun 27, 2023
@smilu97 smilu97 deleted the 10079_pubsub_propa branch June 27, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Redis pubsub request does not unsubscribe on cancel
1 participant