Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10549] Use MapStruct to Mapping model to Protobuf in agent #10283

Merged

Conversation

intr3p1d
Copy link
Contributor

@intr3p1d intr3p1d commented Sep 4, 2023

No description provided.

@intr3p1d intr3p1d added this to the 2.6.0 milestone Sep 4, 2023
@intr3p1d intr3p1d self-assigned this Sep 4, 2023
@codecov
Copy link

codecov bot commented Sep 4, 2023

Codecov Report

Attention: 44 lines in your changes are missing coverage. Please review.

Comparison is base (ce49afa) 38.11% compared to head (4be4e0d) 37.88%.

Files Patch % Lines
...r/context/grpc/mapper/ExceptionMetaDataMapper.java 67.74% 5 Missing and 5 partials ⚠️
.../profiler/context/grpc/mapper/AgentStatMapper.java 61.53% 3 Missing and 2 partials ⚠️
...ofiler/context/grpc/mapper/CustomMetricMapper.java 95.41% 2 Missing and 3 partials ⚠️
...t/grpc/GrpcThreadDumpMessageConverterProvider.java 0.00% 4 Missing ⚠️
...ler/context/grpc/mapper/AnnotationValueMapper.java 94.44% 3 Missing and 1 partial ⚠️
...oint/profiler/context/grpc/mapper/MapperUtils.java 20.00% 2 Missing and 2 partials ⚠️
...rofiler/context/grpc/GrpcStatMessageConverter.java 66.66% 3 Missing ⚠️
...ler/context/grpc/config/SpanUriGetterProvider.java 70.00% 2 Missing and 1 partial ⚠️
...nt/profiler/context/grpc/config/SpanUriGetter.java 50.00% 1 Missing and 1 partial ⚠️
...nt/profiler/context/grpc/mapper/UriStatMapper.java 80.00% 1 Missing and 1 partial ⚠️
... and 2 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10283      +/-   ##
============================================
- Coverage     38.11%   37.88%   -0.23%     
+ Complexity    11931    11886      -45     
============================================
  Files          3786     3795       +9     
  Lines         94643    94148     -495     
  Branches      10310    10228      -82     
============================================
- Hits          36070    35667     -403     
+ Misses        55580    55536      -44     
+ Partials       2993     2945      -48     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@intr3p1d intr3p1d force-pushed the use_mapstruct_for_protobufmapping branch 2 times, most recently from e8a578a to 1b50e9b Compare December 8, 2023 07:11
@intr3p1d intr3p1d force-pushed the use_mapstruct_for_protobufmapping branch from 1b50e9b to 426514c Compare December 18, 2023 06:13
@smilu97 smilu97 self-requested a review December 18, 2023 06:26
@intr3p1d intr3p1d changed the title [#noissue] Use MapStruct to Mapping model to Protobuf in agent [#10549] Use MapStruct to Mapping model to Protobuf in agent Dec 18, 2023
@intr3p1d intr3p1d force-pushed the use_mapstruct_for_protobufmapping branch from 426514c to a109c3e Compare December 22, 2023 06:31
@intr3p1d intr3p1d force-pushed the use_mapstruct_for_protobufmapping branch from a109c3e to 4be4e0d Compare January 22, 2024 05:47
@intr3p1d intr3p1d merged commit b028480 into pinpoint-apm:master Jan 22, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant