Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Refactor PathRewriter #10337

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Sep 14, 2023

No description provided.

@emeroad emeroad force-pushed the #noissue_rewrite branch 3 times, most recently from 38e7b96 to 61ebda8 Compare September 14, 2023 04:04
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Patch coverage: 95.55% and project coverage change: +0.02% 🎉

Comparison is base (bfbac88) 37.85% compared to head (61ebda8) 37.88%.

❗ Current head 61ebda8 differs from pull request most recent head df87eef. Consider uploading reports for the commit df87eef to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10337      +/-   ##
============================================
+ Coverage     37.85%   37.88%   +0.02%     
- Complexity    11950    11963      +13     
============================================
  Files          3761     3763       +2     
  Lines         96493    96502       +9     
  Branches      10621    10625       +4     
============================================
+ Hits          36529    36558      +29     
+ Misses        56860    56845      -15     
+ Partials       3104     3099       -5     
Files Changed Coverage Δ
...corp/pinpoint/web/servlet/DefaultVersionToken.java 75.00% <75.00%> (ø)
.../pinpoint/web/servlet/HttpIntentRoutingFilter.java 61.90% <100.00%> (+9.98%) ⬆️
...rp/pinpoint/web/servlet/VersionPrefixRewriter.java 100.00% <100.00%> (ø)

... and 7 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit 4a29fe5 into pinpoint-apm:master Sep 14, 2023
1 check passed
@emeroad emeroad deleted the #noissue_rewrite branch September 14, 2023 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant