Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#10355] Fix servlet response http-status-recorder #10357

Merged

Conversation

jaehong-kim
Copy link
Contributor

@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Patch coverage: 28.57% and project coverage change: +0.01% 🎉

Comparison is base (5eb8d5f) 37.94% compared to head (3b7c65d) 37.95%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10357      +/-   ##
============================================
+ Coverage     37.94%   37.95%   +0.01%     
- Complexity    11798    11802       +4     
============================================
  Files          3739     3739              
  Lines         94691    94670      -21     
  Branches      10395    10394       -1     
============================================
+ Hits          35929    35934       +5     
+ Misses        55733    55709      -24     
+ Partials       3029     3027       -2     
Files Changed Coverage Δ
...otstrap/plugin/request/ServletRequestListener.java 0.00% <0.00%> (ø)
.../plugin/request/ServletRequestListenerBuilder.java 0.00% <ø> (ø)
...strap/plugin/response/ServletResponseListener.java 0.00% <0.00%> (ø)
...lugin/response/ServletResponseListenerBuilder.java 0.00% <0.00%> (ø)
...nterceptor/StandardHostValveInvokeInterceptor.java 65.15% <ø> (-0.53%) ⬇️
...netty/interceptor/HttpServerHandleInterceptor.java 0.00% <ø> (ø)
...nterceptor/StandardHostValveInvokeInterceptor.java 0.00% <ø> (ø)
...nterceptor/StandardHostValveInvokeInterceptor.java 0.00% <ø> (ø)
.../bootstrap/plugin/http/HttpStatusCodeRecorder.java 56.52% <100.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaehong-kim jaehong-kim merged commit 344121a into pinpoint-apm:master Sep 21, 2023
2 of 3 checks passed
@jaehong-kim jaehong-kim deleted the fix-servlet-response-listener branch September 21, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant