Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#noissue] Refactor mybatis configuration #10411

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

emeroad
Copy link
Member

@emeroad emeroad commented Oct 13, 2023

[#noissue] Cleanup

@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (11c9e2a) 38.16% compared to head (862b49b) 38.25%.

Additional details and impacted files
@@             Coverage Diff              @@
##             master   #10411      +/-   ##
============================================
+ Coverage     38.16%   38.25%   +0.08%     
- Complexity    11775    11780       +5     
============================================
  Files          3725     3723       -2     
  Lines         93859    93656     -203     
  Branches      10241    10229      -12     
============================================
+ Hits          35824    35827       +3     
+ Misses        55029    54826     -203     
+ Partials       3006     3003       -3     
Files Coverage Δ
...p/pinpoint/pinot/mybatis/MyBatisConfiguration.java 0.00% <ø> (ø)
.../com/navercorp/pinpoint/web/PinpointWebModule.java 0.00% <ø> (ø)
...n/config/MetricCollectorPinotDaoConfiguration.java 0.00% <0.00%> (ø)
...ric/web/config/MetricWebPinotDaoConfiguration.java 0.00% <0.00%> (ø)
...inspector/web/config/InspectorRegistryHandler.java 0.00% <0.00%> (ø)
...eb/config/ExceptionTracePinotDaoConfiguration.java 0.00% <0.00%> (ø)
...race/web/config/ExceptionTraceRegistryHandler.java 0.00% <0.00%> (ø)
.../web/config/InspectorWebPinotDaoConfiguration.java 0.00% <0.00%> (ø)
...pinpoint/metric/web/config/WebRegistryHandler.java 0.00% <0.00%> (ø)
...nt/metric/common/config/CommonRegistryHandler.java 0.00% <0.00%> (ø)
... and 2 more

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@emeroad emeroad merged commit 1ed2177 into pinpoint-apm:master Oct 17, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant